Skip to content

introduce DrawingMode to reduce switching #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 28, 2017

Conversation

koron
Copy link
Member

@koron koron commented Nov 28, 2017

描画モードを集中的に管理することで、
AssureXxxやFlushXxxを呼び出す煩雑さからの脱却を目指した。

合わせて意図せぬモード変更を避けやすくなるはず。

@koron koron requested a review from k-takata November 28, 2017 11:46
@koron
Copy link
Member Author

koron commented Nov 28, 2017

mInteropHDC != NULL のチェックをしているところは
mDMode == DM_INTEROP に置き換えたほうが、意味が通りやすいかも。

@codecov
Copy link

codecov bot commented Nov 28, 2017

Codecov Report

Merging #2 into improve-color-emoji will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@                   Coverage Diff                   @@
##           improve-color-emoji       #2      +/-   ##
=======================================================
+ Coverage                74.52%   74.52%   +<.01%     
=======================================================
  Files                       91       91              
  Lines                   132415   132415              
  Branches                 30807    29083    -1724     
=======================================================
+ Hits                     98682    98688       +6     
+ Misses                   33704    33698       -6     
  Partials                    29       29
Impacted Files Coverage Δ
src/if_xcmdsrv.c 83.63% <0%> (-0.72%) ⬇️
src/gui.c 47.4% <0%> (-0.06%) ⬇️
src/gui_gtk_x11.c 47.65% <0%> (-0.05%) ⬇️
src/terminal.c 64.92% <0%> (+0.06%) ⬆️
src/os_unix.c 54.37% <0%> (+0.13%) ⬆️
src/ex_cmds.c 78.08% <0%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96b3c27...040aae7. Read the comment docs.

@koron
Copy link
Member Author

koron commented Nov 28, 2017

mDMode == DM_INTEROP に置き換えたほうが、意味が通りやすい

やっといた。

@k-takata k-takata changed the title introduce DwraingMode to reduce switching introduce DrawingMode to reduce switching Nov 28, 2017
if (mInteropHDC == NULL)
hr = mGDIRT->GetDC(D2D1_DC_INITIALIZE_MODE_COPY, &mInteropHDC);

switch (mode) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

この { は次の行かな。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@k-takata k-takata merged commit 99eb52b into improve-color-emoji Nov 28, 2017
@k-takata k-takata deleted the drawing-mode branch November 28, 2017 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants