WIP: Optimize directx #3
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redraw directly instead of using WM_PAINT.
When updating the cursor, functions were called in the following sequence: * out_flush() * gui_update_cursor() * gui_mch_flush() However, out_flush() itself calls gui_mch_flush() from inside it (through some functions). Therefore gui_mch_flush() was called twice. Unfortunately gui_mch_flush() is very slow when the directx renderer is used. Now the out_flush_cursor() function can be used instead of those 3 functions. It issues gui_mch_flush() only once after drawing the cursor. This also disables issuing gui_mch_flush() via update_single_line() in the main_loop() function.
Codecov Report
@@ Coverage Diff @@
## master #3 +/- ##
==========================================
+ Coverage 74.34% 74.6% +0.26%
==========================================
Files 92 92
Lines 143868 132935 -10933
==========================================
- Hits 106956 99176 -7780
+ Misses 36912 33759 -3153
Continue to review full report at Codecov.
|
When doing `dd`, sometimes cursor was left in a wrong place.
Now scrlines:0 becomes fast enough and no need to set sclines >= 1 anymore. Make it deprecated.
|
I created a PR to the official repository: vim#2560 |
|
Merged as 8.0.1449. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a report that
8.0.13698.0.1343 caused slowdown on some environment:https://groups.google.com/d/msg/vim_dev/2AaZMN1T6K8/x4QxC_XbBQAJ
This PR is trying to solve it.