Async.Promise: Remove test helper wait_has_key_with_timeout #714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* I needed this to fix a flaky test, but after fixing the root cause instead,
we no longer need to specify the timeout from each test case.
* Not having many helper functions in the test increases the maintainability
* #713 (comment)
* I kept the `timeout` as a hard-coded local var instead of hard-coding into the logic as its original form,
for the ease of debug in the future. The runtime cost is ignorable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we no longer need to specify the timeout from each test case.
timeoutas a hard-coded local var instead of hard-coding into the logic as its original form,for the ease of debug in the future. The runtime cost is ignorable.