`syntax/tex.vim` should link `texBoldStyle`, `texItalStyle`, etc. to `Bold`, `Italic`, etc.

[jwodder]

As of Vim 9.1.1800, the syntax/tex.vim file in $VIMRUNTIME contains the following lines, among others:

hi texBoldStyle		gui=bold	cterm=bold
hi texItalStyle		gui=italic	cterm=italic
hi texBoldItalStyle		gui=bold,italic cterm=bold,italic
hi texItalBoldStyle		gui=bold,italic cterm=bold,italic

However, if one is using a colorscheme that begins with highlight clear (as all builtin colorschemes do and as the recommended template for new colorschemes does), then these highlights will be cleared, which is not desired. The highlights for these groups should instead be defined as links to the Bold etc. group, something like:

hi def link texBoldStyle Bold
hi def link texItalStyle Italic
hi def link texBoldItalStyle BoldItalic
hi def link texItalBoldStyle BoldItalic

(This bug report arises from https://vi.stackexchange.com/q/47249/1044.)

[jwodder]

A similar problem also applies to highlight groups like htmlBold and rstEmphasis. Should separate issues be filed for these, or should this issue be widened?

[chrisbra]

Ideally those changes need to go through the respective runtime file maintainers. So please try to reach them first. I'll updated syntex/tex.vim for now

[jwodder]

Ideally those changes need to go through the respective runtime file maintainers. So please try to reach them first.

Do I just e-mail the people listed as maintainers in each affected syntax file, or should I try @-ing them on GitHub, or something else?

[chrisbra]

Either way should be fine.

[marshallward]

I tested hi def link rstEmphasis Italic and hi def rstStrongEmphasis Bold on my end and they seem to work as expected. I would support this change.

The explicit ctermfg= is probably a bad idea overall, but we could keep supporting it with something like this:

hi def link rstEmphasis Italic
hi def link rstStrongEmphasis Bold
if exists('g:rst_use_emphasis_colors')
    highlight! rstItalic ctermfg=13 term=italic cterm=italic gui=italic
    highlight! link rstEmphasis rstItalic
    highlight! rstBold ctermfg=1 term=bold cterm=bold gui=bold
    highlight! link rstStrongEmphasis rstBold
endif

It would probably still cause problems with TeX as described above, but it's also a fairly obscure setting that would not affect most users. (There's also probably many better solutions...)