Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dynamic loading of libsodium #11667

Closed
wants to merge 1 commit into from
Closed

Conversation

k-takata
Copy link
Member

@k-takata k-takata commented Dec 6, 2022

When dynamic loading is used for libsodium, link error occurs after #11656. Fix it.

When dynamic loading is used for libsodium, link error occurs after vim#11656.
Fix it.
@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #11667 (5aa57b2) into master (7155fb6) will decrease coverage by 0.00%.
The diff coverage is 14.28%.

@@            Coverage Diff             @@
##           master   #11667      +/-   ##
==========================================
- Coverage   81.85%   81.84%   -0.01%     
==========================================
  Files         164      164              
  Lines      190484   190488       +4     
  Branches    43294    43294              
==========================================
- Hits       155914   155907       -7     
- Misses      21934    21953      +19     
+ Partials    12636    12628       -8     
Flag Coverage Δ
huge-clang-none 82.71% <14.28%> (-0.01%) ⬇️
huge-gcc-none 54.60% <0.00%> (+<0.01%) ⬆️
huge-gcc-testgui 53.05% <0.00%> (+<0.01%) ⬆️
huge-gcc-unittests 0.29% <0.00%> (ø)
linux 82.47% <14.28%> (-0.01%) ⬇️
mingw-x64-HUGE 76.28% <0.00%> (+0.01%) ⬆️
mingw-x86-HUGE 77.07% <0.00%> (+<0.01%) ⬆️
windows 77.92% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/evalfunc.c 90.74% <0.00%> (ø)
src/crypt.c 73.89% <20.00%> (-1.11%) ⬇️
src/ui.c 75.85% <0.00%> (-2.69%) ⬇️
src/os_win32.c 59.70% <0.00%> (-0.11%) ⬇️
src/gui_gtk_x11.c 51.74% <0.00%> (-0.10%) ⬇️
src/mbyte.c 72.70% <0.00%> (-0.07%) ⬇️
src/os_unix.c 67.20% <0.00%> (-0.05%) ⬇️
src/regexp_nfa.c 89.82% <0.00%> (-0.04%) ⬇️
src/regexp_bt.c 86.00% <0.00%> (+0.04%) ⬆️
src/term.c 73.72% <0.00%> (+0.04%) ⬆️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@brammool brammool closed this in a8cdb4e Dec 6, 2022
@k-takata k-takata deleted the fix-dyn-sodium branch December 6, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant