Add just filetype #13271
Closed
Add just filetype #13271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks! |
zeertzjq
reviewed
Oct 5, 2023
| @@ -1093,6 +1093,9 @@ au BufNewFile,BufRead *.jsonnet,*.libsonnet setf jsonnet | |||
| " Julia | |||
| au BufNewFile,BufRead *.jl setf julia | |||
|
|
|||
| " Just | |||
| autocmd BufNewFile,BufRead *[jJ]ustfile,.justfile,*.just setfiletype just | |||
There was a problem hiding this comment.
The autocommand in https://github.com/NoahTheDuke/vim-just/blob/main/ftdetect/just.vim doesn't have a * before the \cjustfile, so having a * before [jJ]ustfile looks strange. Also it should be au and setf here for consistency, not autocmd and setfiletype.
clason
added a commit
to clason/neovim
that referenced
this pull request
Oct 5, 2023
Problem: No filetype detection for just files Solution: Detect just files (*.just, justfile, etc) closes: vim/vim#13271 vim/vim@3d90f71 Co-authored-by: dundargoc <gocdundar@gmail.com>
dundargoc
added a commit
to dundargoc/vim
that referenced
this pull request
Oct 5, 2023
dundargoc
added a commit
to dundargoc/vim
that referenced
this pull request
Oct 5, 2023
chrisbra
pushed a commit
that referenced
this pull request
Oct 5, 2023
See #13271 (comment) and https://github.com/NoahTheDuke/vim-just/blob/main/ftdetect/just.vim. Signed-off-by: Christian Brabandt <cb@256bit.org>
clason
added a commit
to clason/neovim
that referenced
this pull request
Oct 5, 2023
Problem: No filetype detection for just files Solution: Detect just files (*.just, justfile, etc) closes: vim/vim#13271 vim/vim@3d90f71 vim-patch:b6d01f13: runtime(just): Correct filetype detection pattern and style Co-authored-by: dundargoc <gocdundar@gmail.com>
clason
added a commit
to neovim/neovim
that referenced
this pull request
Oct 6, 2023
Problem: No filetype detection for just files Solution: Detect just files (*.just, justfile, etc) closes: vim/vim#13271 vim/vim@3d90f71 vim-patch:b6d01f13: runtime(just): Correct filetype detection pattern and style Co-authored-by: dundargoc <gocdundar@gmail.com>
chrisbra
pushed a commit
to chrisbra/vim
that referenced
this pull request
Oct 7, 2023
See vim#13271 (comment) and https://github.com/NoahTheDuke/vim-just/blob/main/ftdetect/just.vim. Signed-off-by: Christian Brabandt <cb@256bit.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.