Add checkgroups Makefile target to check default hl group links. #16678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbra
reviewed
Feb 20, 2025
|
shouldn't we call this script in https://github.com/vim/vim/blob/master/.github/workflows/ci.yml like the vimtags target? |
|
Hi,
Op do 20 feb 2025 21:48 schreef Christian Brabandt <
***@***.***>:
shouldn't we call this script in
https://github.com/vim/vim/blob/master/.github/workflows/ci.yml like the
vimtags target?
—
Reply to this email directly, view it on GitHub
<#16678 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACY5DGDFWTB55QV4I2RC7H32QY5RDAVCNFSM6AAAAABXQKOREWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZSGY2DIOBUGM>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
[image: chrisbra]*chrisbra* left a comment (vim/vim#16678)
<#16678 (comment)>
shouldn't we call this script in
https://github.com/vim/vim/blob/master/.github/workflows/ci.yml like the
vimtags target?
Yes, I'm trying to get this in CI.
The reason I (temporarily) removed the "default link" in ``highlight.c``
was because I was trying to fall CI in the "intended" way: that it needed
to be specified.
I should probably change this to a WIP for now... I'll let you know when
this is done.
Christ van Willegen
… |
|
Hi,
Op do 20 feb 2025 21:53 schreef Christ van Willegen ***@***.***>:
shouldn't we call this script in
> https://github.com/vim/vim/blob/master/.github/workflows/ci.yml like the
> vimtags target?
>
> —
> Reply to this email directly, view it on GitHub
> <#16678 (comment)>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ACY5DGDFWTB55QV4I2RC7H32QY5RDAVCNFSM6AAAAABXQKOREWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZSGY2DIOBUGM>
> .
> You are receiving this because you are subscribed to this thread.Message
> ID: ***@***.***>
> [image: chrisbra]
>
Yes, I'm trying to get this in CI.
Ah, the reason I couldn't find where the Filelist is checked is that is in
a hidden directory, so ``grep`` doesn't find it. Thanks for the pointer!
Christ van Willegen
… |
|
I think this is done now. |
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding highlight groups, you may need to add a "default link NewHlGroup ExistingHlGroup" in highlight.c code, so that when resetting a color scheme an old color will not be left behind.
Added a Makefile target in the 'runtime/doc' directory that checks if hl- groups that were added to the documentation are either reflected in the source code, or belong to a list of 'known to be ignored' highlight groups.