Fix: 'autocompletedelay' handling with "preinsert" and "longest" #18460
+126
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR addresses multiple issues in the 'autocompletedelay' behavior with "preinsert" and "longest". * Prevents spurious characters from being inserted. * Ensures the completion menu is not shown until `autocompletedelay` has expired. * Shows the *preinsert* effect immediately. * Keeps the *preinsert* effect visible even when a character is deleted.
|
thanks |
|
thanks |
zeertzjq
added a commit
to zeertzjq/neovim
that referenced
this pull request
Oct 3, 2025
Problem: completion: some issues with 'acl' when "preinsert" and
"longest" is in 'completeopt' (musonius, after v9.1.1638)
Solution: Fix various issues (see details below) (Girish Palya)
This commit addresses multiple issues in the 'autocompletedelay' behavior with
"preinsert" and "longest":
- Prevents spurious characters from being inserted.
- Ensures the completion menu is not shown until `autocompletedelay` has
expired.
- Shows the "preinsert" effect immediately.
- Keeps the "preinsert" effect visible even when a character is deleted.
fixes: vim/vim#18443
closes: vim/vim#18460
vim/vim@f77c187
Co-authored-by: Girish Palya <girishji@gmail.com>
zeertzjq
added a commit
to neovim/neovim
that referenced
this pull request
Oct 3, 2025
Problem: completion: some issues with 'acl' when "preinsert" and
"longest" is in 'completeopt' (musonius, after v9.1.1638)
Solution: Fix various issues (see details below) (Girish Palya)
This commit addresses multiple issues in the 'autocompletedelay' behavior with
"preinsert" and "longest":
- Prevents spurious characters from being inserted.
- Ensures the completion menu is not shown until `autocompletedelay` has
expired.
- Shows the "preinsert" effect immediately.
- Keeps the "preinsert" effect visible even when a character is deleted.
fixes: vim/vim#18443
closes: vim/vim#18460
vim/vim@f77c187
Co-authored-by: Girish Palya <girishji@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses multiple issues in the 'autocompletedelay' behavior with "preinsert" and "longest".
autocompletedelayhas expired.Fixes #18443