Fix: Issue 18488 #18497
Closed
Fix: Issue 18488 #18497
+72
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes vim#18488 NOTE: If completion items are already fuzzy-sorted during collection (for example, when a user or omni function returns a pre-sorted list), an additional redundant sort will still occur within the completion mechanism. This is harmless — the list is typically small, and the sorting operation (O(N log N)) remains efficient even for linked lists. No need for premature optimization.
|
This pr give sorted list is different with typing resorted list. It seems that there is no sorting between the sources? Is this expected or an error? set cfc=keyword cot+=noselect,fuzzy
augroup group_vim_ins_completion
autocmd!
autocmd FileType vim
\ setlocal omnifunc=vimcomplete#Complete |
\ setlocal complete+=o^7
augroup ENDbefore resort by <C-h><BeforeChar> this pr |
M src/insexpand.c M src/testdir/test_ins_complete.vim
|
There was a bug. Pl. try now. |
|
I have tested, no problem. |
|
thanks |
zeertzjq
added a commit
to zeertzjq/neovim
that referenced
this pull request
Oct 7, 2025
Problem: completion: fuzzy candidates are not sorted
(ddad431)
Solution: Always sort fuzzy candidates (Girish Palya)
fixes: vim/vim#18488
closes: vim/vim#18497
vim/vim@10aa04e
Co-authored-by: Girish Palya <girishji@gmail.com>
zeertzjq
added a commit
to neovim/neovim
that referenced
this pull request
Oct 7, 2025
Problem: completion: fuzzy candidates are not sorted
(ddad431)
Solution: Always sort fuzzy candidates (Girish Palya)
fixes: vim/vim#18488
closes: vim/vim#18497
vim/vim@10aa04e
Co-authored-by: Girish Palya <girishji@gmail.com>
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18488
NOTE: If completion items are already fuzzy-sorted during collection (for example, when a user or omni function returns a pre-sorted list), an additional redundant sort will still occur within the completion mechanism. This is harmless — the list is typically small, and the sorting operation (O(N log N)) remains efficient even for linked lists. No need for premature optimization.