Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow method-like strings in referencedFunction #10071

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Conversation

weirdan
Copy link
Collaborator

@weirdan weirdan commented Aug 1, 2023

Fixes #10070

@weirdan weirdan added the release:fix The PR will be included in 'Fixes' section of the release notes label Aug 1, 2023
@weirdan weirdan requested a review from orklah August 1, 2023 04:38
@weirdan
Copy link
Collaborator Author

weirdan commented Aug 1, 2023

Test failures seem unrelated

@orklah
Copy link
Collaborator

orklah commented Aug 1, 2023

Thanks!

@orklah orklah merged commit b9d355e into vimeo:5.x Aug 1, 2023
47 of 48 checks passed
oguzhand95 referenced this pull request in cerbos/cerbos-sdk-php Aug 7, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[google/common-protos](https://togithub.com/googleapis/common-protos-php)
| require | minor | `4.1.0` -> `4.2.0` |
| [phpstan/phpstan](https://togithub.com/phpstan/phpstan) | require-dev
| patch | `1.10.26` -> `1.10.27` |
| [phpunit/phpunit](https://phpunit.de/)
([source](https://togithub.com/sebastianbergmann/phpunit)) | require-dev
| minor | `10.2.6` -> `10.3.1` |
| [vimeo/psalm](https://togithub.com/vimeo/psalm) | require-dev | minor
| `5.13.1` -> `5.14.1` |

---

### Release Notes

<details>
<summary>googleapis/common-protos-php (google/common-protos)</summary>

###
[`v4.2.0`](https://togithub.com/googleapis/common-protos-php/blob/HEAD/CHANGELOG.md#420-2023-07-25)

[Compare
Source](https://togithub.com/googleapis/common-protos-php/compare/v4.1.0...v4.2.0)

##### Features

- Add a proto message to describe the `resource_type` and
`resource_permission` for an API method
([#&#8203;64](https://togithub.com/googleapis/common-protos-php/issues/64))
([8a0ff5f](https://togithub.com/googleapis/common-protos-php/commit/8a0ff5f9ffcf3683fc4718e85e97f45a001a1925))

</details>

<details>
<summary>phpstan/phpstan (phpstan/phpstan)</summary>

###
[`v1.10.27`](https://togithub.com/phpstan/phpstan/releases/tag/1.10.27)

[Compare
Source](https://togithub.com/phpstan/phpstan/compare/1.10.26...1.10.27)

# Bleeding edge 🔪

- More precise `stream_socket_client()` signature
([#&#8203;2519](https://togithub.com/phpstan/phpstan-src/pull/2519)),
thanks [@&#8203;staabm](https://togithub.com/staabm)!
- More precise `scandir()` signature
([#&#8203;2518](https://togithub.com/phpstan/phpstan-src/pull/2518)),
thanks [@&#8203;staabm](https://togithub.com/staabm)!
- More precise `extract()` signature
([#&#8203;2517](https://togithub.com/phpstan/phpstan-src/pull/2517)),
thanks [@&#8203;staabm](https://togithub.com/staabm)!

*If you want to see the shape of things to come and adopt bleeding edge
features early, you can include this config file in your project's
`phpstan.neon`:*

    includes:
    	- vendor/phpstan/phpstan/conf/bleedingEdge.neon

*Of course, there are no backwards compatibility guarantees when you
include this file. The behaviour and reported errors can change in minor
versions with this file included. [Learn
more](https://phpstan.org/blog/what-is-bleeding-edge)*

# Improvements 🔧

- Report trait access to unititialized property in the trait instead of
class
([#&#8203;2531](https://togithub.com/phpstan/phpstan-src/pull/2531)),
thanks [@&#8203;schlndh](https://togithub.com/schlndh)!
- Type projections, part 2: enforce elementary rules
([#&#8203;2481](https://togithub.com/phpstan/phpstan-src/pull/2481)),
thanks [@&#8203;jiripudil](https://togithub.com/jiripudil)!
- Unify ignoring lines in traits with parser tokens
(phpstan/phpstan-src@01294d8),
[#&#8203;6175](https://togithub.com/phpstan/phpstan/issues/6175)

# Bugfixes 🐛

- Fix json method exception
([#&#8203;2524](https://togithub.com/phpstan/phpstan-src/pull/2524)),
[#&#8203;9568](https://togithub.com/phpstan/phpstan/issues/9568), thanks
[@&#8203;VincentLanglet](https://togithub.com/VincentLanglet)!
- Support of printf with dynamic width
([#&#8203;2543](https://togithub.com/phpstan/phpstan-src/pull/2543)),
[#&#8203;9674](https://togithub.com/phpstan/phpstan/issues/9674), thanks
[@&#8203;kukulich](https://togithub.com/kukulich)!
- Support of printf with dynamic precision (and improved support of
dynamic width)
([#&#8203;2544](https://togithub.com/phpstan/phpstan-src/pull/2544)),
[#&#8203;9677](https://togithub.com/phpstan/phpstan/issues/9677), thanks
[@&#8203;kukulich](https://togithub.com/kukulich)!
- Fix types for conditional parameters after checks
([#&#8203;2548](https://togithub.com/phpstan/phpstan-src/pull/2548)),
[#&#8203;7915](https://togithub.com/phpstan/phpstan/issues/7915), thanks
[@&#8203;rvanvelzen](https://togithub.com/rvanvelzen)!
- Prevent `Call to end() on null`
(phpstan/phpstan-src@a5e5719),
[#&#8203;9722](https://togithub.com/phpstan/phpstan/issues/9722)
- Fix internal error in SimpleXMLElementConstructorThrowTypeExtension
([#&#8203;2561](https://togithub.com/phpstan/phpstan-src/pull/2561)),
[#&#8203;9716](https://togithub.com/phpstan/phpstan/issues/9716), thanks
[@&#8203;staabm](https://togithub.com/staabm)!
- Method extensions class name is case-insensitive
([#&#8203;2562](https://togithub.com/phpstan/phpstan-src/pull/2562)),
[#&#8203;9716](https://togithub.com/phpstan/phpstan/issues/9716), thanks
[@&#8203;staabm](https://togithub.com/staabm)!
- InArrayFunctionTypeSpecifyingExtension - fix calls with less than 2
parameters
(phpstan/phpstan-src@4d77e98),
[#&#8203;9711](https://togithub.com/phpstan/phpstan/issues/9711)

# Function signature fixes 🤖

- `uopz_flags` - flags are optional
(phpstan/phpstan-src@917750e),
[#&#8203;9611](https://togithub.com/phpstan/phpstan/issues/9611)
- Add `base64_decode` overloads to PHP 8+
([#&#8203;2529](https://togithub.com/phpstan/phpstan-src/pull/2529)),
[#&#8203;9428](https://togithub.com/phpstan/phpstan/issues/9428), thanks
[@&#8203;dktapps](https://togithub.com/dktapps)!
- Mark few Ds methods as impure
([#&#8203;2550](https://togithub.com/phpstan/phpstan-src/pull/2550)),
thanks [@&#8203;simPod](https://togithub.com/simPod)!

# Internals 🔍

- Avoid doing work before its necessary in mutating scope.
([#&#8203;2537](https://togithub.com/phpstan/phpstan-src/pull/2537)),
thanks [@&#8203;mad-briller](https://togithub.com/mad-briller)!
- Changed `linesToIgnore` attribute format
(phpstan/phpstan-src@2862a7b)
- Prevent unnecessary work in MutatingScope
([#&#8203;2554](https://togithub.com/phpstan/phpstan-src/pull/2554)),
thanks [@&#8203;staabm](https://togithub.com/staabm)!
- Validate parameters with parametersSchema each time after container
creation
([#&#8203;2558](https://togithub.com/phpstan/phpstan-src/pull/2558))

</details>

<details>
<summary>sebastianbergmann/phpunit (phpunit/phpunit)</summary>

###
[`v10.3.1`](https://togithub.com/sebastianbergmann/phpunit/compare/10.3.0...10.3.1)

[Compare
Source](https://togithub.com/sebastianbergmann/phpunit/compare/10.3.0...10.3.1)

###
[`v10.3.0`](https://togithub.com/sebastianbergmann/phpunit/compare/10.2.7...10.3.0)

[Compare
Source](https://togithub.com/sebastianbergmann/phpunit/compare/10.2.7...10.3.0)

###
[`v10.2.7`](https://togithub.com/sebastianbergmann/phpunit/compare/10.2.6...10.2.7)

[Compare
Source](https://togithub.com/sebastianbergmann/phpunit/compare/10.2.6...10.2.7)

</details>

<details>
<summary>vimeo/psalm (vimeo/psalm)</summary>

### [`v5.14.1`](https://togithub.com/vimeo/psalm/releases/tag/5.14.1)

[Compare
Source](https://togithub.com/vimeo/psalm/compare/5.14.0...5.14.1)

<!-- Release notes generated using configuration in .github/release.yml
at 5.x -->

#### What's Changed

##### Fixes

- Allow method-like strings in `referencedFunction` by
[@&#8203;weirdan](https://togithub.com/weirdan) in
[https://github.com/vimeo/psalm/pull/10071](https://togithub.com/vimeo/psalm/pull/10071)

**Full Changelog**:
vimeo/psalm@5.14.0...5.14.1

### [`v5.14.0`](https://togithub.com/vimeo/psalm/releases/tag/5.14.0)

[Compare
Source](https://togithub.com/vimeo/psalm/compare/5.13.1...5.14.0)

<!-- Release notes generated using configuration in .github/release.yml
at 5.x -->

#### What's Changed

##### Features

- Infer output format from GITHUB_ACTIONS env by
[@&#8203;ro0NL](https://togithub.com/ro0NL) in
[https://github.com/vimeo/psalm/pull/9982](https://togithub.com/vimeo/psalm/pull/9982)
- fix mixed replace return types for arrays by
[@&#8203;kkmuffme](https://togithub.com/kkmuffme) in
[https://github.com/vimeo/psalm/pull/9981](https://togithub.com/vimeo/psalm/pull/9981)
- make stubbed constant types configurable with comment by
[@&#8203;kkmuffme](https://togithub.com/kkmuffme) in
[https://github.com/vimeo/psalm/pull/9992](https://togithub.com/vimeo/psalm/pull/9992)
- Allow space before array shape opening brace and added unit tests by
[@&#8203;rhertogh](https://togithub.com/rhertogh) in
[https://github.com/vimeo/psalm/pull/10000](https://togithub.com/vimeo/psalm/pull/10000)
- Add generic stubs for MongoDB BSON classes by
[@&#8203;alcaeus](https://togithub.com/alcaeus) in
[https://github.com/vimeo/psalm/pull/10016](https://togithub.com/vimeo/psalm/pull/10016)
- Allow comments in types (e.g. in array shapes) by
[@&#8203;rhertogh](https://togithub.com/rhertogh) in
[https://github.com/vimeo/psalm/pull/10004](https://togithub.com/vimeo/psalm/pull/10004)
- [#&#8203;10030](https://togithub.com/vimeo/psalm/issues/10030) Fix
missing TaintedSql by [@&#8203;cgocast](https://togithub.com/cgocast) in
[https://github.com/vimeo/psalm/pull/10032](https://togithub.com/vimeo/psalm/pull/10032)
- Automatic LSP container path mapping by
[@&#8203;weirdan](https://togithub.com/weirdan) in
[https://github.com/vimeo/psalm/pull/10033](https://togithub.com/vimeo/psalm/pull/10033)
- added GitHub CI for unit tests with PHP 8.2 and 8.3 by
[@&#8203;thbley](https://togithub.com/thbley) in
[https://github.com/vimeo/psalm/pull/10028](https://togithub.com/vimeo/psalm/pull/10028)
- Modernize LSP progress reporting by
[@&#8203;weirdan](https://togithub.com/weirdan) in
[https://github.com/vimeo/psalm/pull/10050](https://togithub.com/vimeo/psalm/pull/10050)
- Add type detection for PDOStatement::fetchAll(PDO::FETCH_CLASS,
SomeClass::class) by [@&#8203;thbley](https://togithub.com/thbley) in
[https://github.com/vimeo/psalm/pull/10055](https://togithub.com/vimeo/psalm/pull/10055)

##### Fixes

- Fix sprintf single arg splat array by
[@&#8203;kkmuffme](https://togithub.com/kkmuffme) in
[https://github.com/vimeo/psalm/pull/9975](https://togithub.com/vimeo/psalm/pull/9975)
- Fixed exhuming enums as enums, not as classes by
[@&#8203;ygottschalk](https://togithub.com/ygottschalk) in
[https://github.com/vimeo/psalm/pull/9988](https://togithub.com/vimeo/psalm/pull/9988)
- Missing composer lock should not invalidate cache created with missing
composer lock by [@&#8203;kkmuffme](https://togithub.com/kkmuffme) in
[https://github.com/vimeo/psalm/pull/9970](https://togithub.com/vimeo/psalm/pull/9970)
- no error for printf with only 1 arg by
[@&#8203;kkmuffme](https://togithub.com/kkmuffme) in
[https://github.com/vimeo/psalm/pull/9993](https://togithub.com/vimeo/psalm/pull/9993)
- Fix "days" falsable return not ignored consistently by
[@&#8203;kkmuffme](https://togithub.com/kkmuffme) in
[https://github.com/vimeo/psalm/pull/9998](https://togithub.com/vimeo/psalm/pull/9998)
- offsetExists/Get/Set/Unset types were too generic by
[@&#8203;kkmuffme](https://togithub.com/kkmuffme) in
[https://github.com/vimeo/psalm/pull/9999](https://togithub.com/vimeo/psalm/pull/9999)
- Fix inference high order function when closure param is omitted by
[@&#8203;klimick](https://togithub.com/klimick) in
[https://github.com/vimeo/psalm/pull/10014](https://togithub.com/vimeo/psalm/pull/10014)
- Fix incorrect positions set in code action edits by
[@&#8203;weirdan](https://togithub.com/weirdan) in
[https://github.com/vimeo/psalm/pull/10034](https://togithub.com/vimeo/psalm/pull/10034)
- Always report UnusedBaseline issues by
[@&#8203;ygottschalk](https://togithub.com/ygottschalk) in
[https://github.com/vimeo/psalm/pull/10012](https://togithub.com/vimeo/psalm/pull/10012)
- Fix scanning of intersection types by
[@&#8203;danog](https://togithub.com/danog) in
[https://github.com/vimeo/psalm/pull/10043](https://togithub.com/vimeo/psalm/pull/10043)
- Fix combination of non-falsy-string and falsy literal by
[@&#8203;danog](https://togithub.com/danog) in
[https://github.com/vimeo/psalm/pull/10039](https://togithub.com/vimeo/psalm/pull/10039)
- Fix variadic callable type check by
[@&#8203;klimick](https://togithub.com/klimick) in
[https://github.com/vimeo/psalm/pull/10066](https://togithub.com/vimeo/psalm/pull/10066)

##### Internal changes

- Fixed psalm self test by
[@&#8203;ygottschalk](https://togithub.com/ygottschalk) in
[https://github.com/vimeo/psalm/pull/9990](https://togithub.com/vimeo/psalm/pull/9990)
- Fix/phpparser deprecation name parts by
[@&#8203;ygottschalk](https://togithub.com/ygottschalk) in
[https://github.com/vimeo/psalm/pull/9964](https://togithub.com/vimeo/psalm/pull/9964)
- Simplify conditions with deep object access by
[@&#8203;weirdan](https://togithub.com/weirdan) in
[https://github.com/vimeo/psalm/pull/10037](https://togithub.com/vimeo/psalm/pull/10037)
- Map special RPC paths by
[@&#8203;weirdan](https://togithub.com/weirdan) in
[https://github.com/vimeo/psalm/pull/10046](https://togithub.com/vimeo/psalm/pull/10046)

#### New Contributors

- [@&#8203;rhertogh](https://togithub.com/rhertogh) made their first
contribution in
[https://github.com/vimeo/psalm/pull/10000](https://togithub.com/vimeo/psalm/pull/10000)
- [@&#8203;cgocast](https://togithub.com/cgocast) made their first
contribution in
[https://github.com/vimeo/psalm/pull/10032](https://togithub.com/vimeo/psalm/pull/10032)

**Full Changelog**:
vimeo/psalm@5.13.1...5.14.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/cerbos/cerbos-sdk-php).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4yNC4yIiwidXBkYXRlZEluVmVyIjoiMzYuMjcuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Oğuzhan Durgun <oguzhandurgun95@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TooManyArguments does not support methods in issueHandlers
2 participants