Skip to content

Added showstatuslinks values hiding link preview #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 6, 2015
Merged

Added showstatuslinks values hiding link preview #344

merged 1 commit into from
Dec 6, 2015

Conversation

demokritos
Copy link
Contributor

If showstatuslinks is set other than 0, there is redundancy of link
previews. So provides an option to hide the bottom-left corner link
preview.

@maxauthority
Copy link
Member

I think we could make not showing it duplicate the default: I propose:

0
Don't show link destination
1
Show the link destination in the status line
2
Show the link destination in the command line
3
Show the link destination in the content area

3 just being the default as Firefox does. and 0-2 would hide the Firefox
link preview and only show the link within vimperator.

PS: I propose adding the word "destination " to the help instead of "Show
the link in the status line" as it is now.

On Fri, Nov 27, 2015 at 9:55 PM, Taegil Bae notifications@github.com
wrote:

If showstatuslinks is set other than 0, there is redundancy of link
previews. So provides an option to hide the bottom-left corner link

preview.

You can view, comment on, or merge this pull request online at:

#344
Commit Summary

  • Added showstatuslinks values hiding link preview

File Changes

Patch Links:

—
Reply to this email directly or view it on GitHub
#344.

@demokritos
Fixed duplication of the link destination preview
83972c1 
If showstatuslinks was set other than 0, there were two link destination
previews. Hence fixed so that the Firefox's link preview is shown only
when showstatuslinks is 3(new value).
@demokritos
Copy link
Contributor Author

I updated the commit as you proposed.

maxauthority added a commit that referenced this pull request Dec 6, 2015
@maxauthority
Merge pull request #344 from demokritos/dev
2a1ef22 
Added showstatuslinks values hiding link preview
@maxauthority maxauthority merged commit 2a1ef22 into vimperator:master Dec 6, 2015
@gkatsev
Copy link
Member

gkatsev commented Feb 5, 2016

This apparently never got a NEWS entry.

@gkatsev gkatsev mentioned this pull request Feb 5, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@demokritos @maxauthority @gkatsev