Fix broken hints in FF44 #388

[kmorihiro]

The issue seems like a z-index issue.
I confirmed hints was fixed on startpage.

before fix: http://i.imgur.com/LYYLcdb.png
after fix: http://i.imgur.com/MJpYP8O.png

[timss]

Any idea why #297 isn't sufficient anymore?

[kmorihiro]

Hint nodes are covered by other nodes which are siblings of <div highlight="hints" /> and have higher z-index than it, even if Hint nodes have the highest z-index.
<div highlight="hints" /> is the parent node of Hint nodes.
I wrote sample code of the stacking context.

I guess FF 43 or earlier has some bugs in the stacking context.
I'm not sure, but the bug below may be related.
https://bugzilla.mozilla.org/show_bug.cgi?id=725299

[timss]

Great, thanks for the explaination.

Can confirm that the PR works for me.

[gkatsev]

hurray z-index wars :/
LGTM. Thanks.

[jonross]

Thanks, this is good news. Also explains why adding an explicit z-index to hint style in .vimperatorrc doesn't help (first thing I tried!)

Is there an ETA for a release that includes this fix, or a way to affect the top-level hint DIV via the .rc file?

thanks,
Jon

[timss]

@jonross In the event a new release is not made or planned anytime soon, you may look into compiling it yourself, or link {MY_FIREFOX_PROFILE}/extensions/vimperator@mozdev.org to a clone of the repo.

For more information, see http://www.vimperator.org/developerinfo

[gkatsev]

I'd like to merge some of the PRs that are currently open before making another release first.
So, probably not before next week.

[v1kn]

Hints are still broken on startpage in my case. Vimperator 3.11.3.

Should I add sth to .vimperatorrc for hints to work?

[timss]

@v1kn This patch was merged after 3.11.3 was released, so that makes sense.

You're going to want to follow the master branch atleast up until a new release. Either:

1. Clone repo. Issue make and install .xpi created.
2. Clone repo. Add /path/to/clone to $HOME/.mozilla/firefox/yourprofile/extensions/vimperator@mozdev.org.

[v1kn]

@timss Thanks for that, didn't realize the hinting patch hadn't made it to the 3.11.3 release