Disallow units for zero values #541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! LGTM. |
amlitzer
added a commit
to amlitzer/vimperator-labs
that referenced
this pull request
Sep 18, 2016
* master: fix command line Shift+Insert paste on Linux Fix vimperator#444: Honor hlsearch on n/N fix Shift+Insert paste on Linux use saniztizer based on app platform version, vimperator#556 Remove asciidoc.conf Remove regressions.js Fix vimperator#259: Command prompt selection sometimes cleared Fix misspellings (vimperator#546) Optimize vimperator-labs-white.png and about_background.png, reduce file size with optipng Disallow units for zero values (vimperator#541) help.css: Disallow overqualified elements (vimperator#540)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value of 0 works without specifying units in all situations where numbers with length units or percentages are allowed. There is no difference between 0px, 0em, 0%, or any other zero-value. The units aren't important because the value is still zero. CSS allows you to omit the length units for zero values and still remain valid CSS.
It's recommended to remove units for all zero length values because these units aren't being used by the browser and therefore can be safely removed to save bytes.