-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port Scanner Component #157
Port Scanner Component #157
Conversation
Thanks for opening this pull request! 🤗 Check out few other repos below 🚀 PS: Please add @vinitshahdeo / @Kashish121 / @ishika1727 as a reviewer if you haven't added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@devRawnie Some changes:
- Please remove the css from
index.css
. Instead create a fileportscanner.css
in a new folder calledcss
and put the styling in it. - Do not commit any changes in App.js. Revert it back the way it initially was.
Please do the required changes by today EOD
Sure, doing that right away. |
I have committed the new changes as per the requirements. Kindly go through the same |
Good to go. 👍 |
Congrats on merging your first pull request! 🙌🎉⚡️ |
Description
Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context.
List any dependencies that are required for this change.
Created a new PortScanner Form Component as per the given design. Also added logic for validation of the inputs.
Fixes #121
Type of change
Please delete options that are not relevant.
Checklist: