Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Scanner Component #157

Merged
merged 4 commits into from
Mar 15, 2021
Merged

Port Scanner Component #157

merged 4 commits into from
Mar 15, 2021

Conversation

devRawnie
Copy link

@devRawnie devRawnie commented Mar 15, 2021

Description

Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context.
List any dependencies that are required for this change.
Created a new PortScanner Form Component as per the given design. Also added logic for validation of the inputs.

Fixes #121

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules
  • I have added all the three reviewers: @vinitshahdeo, @Kashish121 & @ishika1727

@welcome
Copy link

welcome bot commented Mar 15, 2021

Thanks for opening this pull request! 🤗
Are you looking for more beginner-friendly issues? Check out this repo.

Hacktoberfest2020

Open Source Love

Check out few other repos below 🚀

inspirational-quotes
SimpleBio
HBD
Map Of India

PS: Please add @vinitshahdeo / @Kashish121 / @ishika1727 as a reviewer if you haven't added.

Copy link
Collaborator

@ishika1727 ishika1727 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devRawnie Some changes:

  1. Please remove the css from index.css. Instead create a file portscanner.css in a new folder called css and put the styling in it.
  2. Do not commit any changes in App.js. Revert it back the way it initially was.

Please do the required changes by today EOD

@devRawnie
Copy link
Author

Sure, doing that right away.

@devRawnie devRawnie changed the title Feature/react Port Scanner Component Mar 15, 2021
@devRawnie
Copy link
Author

I have committed the new changes as per the requirements. Kindly go through the same

@ishika1727 ishika1727 added gssoc21 Level3 Major Feature or Bug fix labels Mar 15, 2021
@ishika1727
Copy link
Collaborator

Good to go. 👍

@ishika1727 ishika1727 merged commit 02a43af into vinitshahdeo:feature/react Mar 15, 2021
@welcome
Copy link

welcome bot commented Mar 15, 2021

Congrats on merging your first pull request! 🙌🎉⚡️
Show some love by starring a few of my repositories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc21 Level3 Major Feature or Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants