New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Committed #158

Open

manastole03 wants to merge 1 commit into vinitshahdeo:master from manastole03:frontend

manastole03 commented Mar 15, 2021

Description

Adding a new feature for Dark mode and Light mode

Fixes #123

Type of change

Please delete options that are not relevant.

New feature (non-breaking change which adds functionality)

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
Any dependent changes have been merged and published in downstream modules
I have added all the three reviewers: @vinitshahdeo, @Kashish121 & @ishika1727


          Committed

244819a

welcome bot commented Mar 15, 2021

Thanks for opening this pull request! 🤗
Are you looking for more beginner-friendly issues? Check out this repo.

Check out few other repos below 🚀

PS: Please add @vinitshahdeo / @Kashish121 / @ishika1727 as a reviewer if you haven't added.

ishika1727 requested a review from Kashish121

March 15, 2021 10:53

Collaborator

Kashish121 commented Mar 16, 2021

Hey @manastole03, instead of master branch, please make the corresponding changes in develop branch and then create a PR.

NOTE: master -> python2.x, develop -> python3.x

Author

manastole03 commented Mar 18, 2021

Okay @Kashish121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment