Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#280 - Improve printer graphics tests #281

Merged
merged 6 commits into from
Oct 31, 2020
Merged

Conversation

vintagepc
Copy link
Owner

Description

Removes the stock firmware from graphics tests so they don't take as long

Behaviour/ Breaking changes

Should not break anything, but should speed up tests.

Have you tested the changes?

Locally, also build system will verify

Other

  • Also adds some expanded testing for the LED code and clicks.

Linked issues:

@codecov-io
Copy link

codecov-io commented Oct 31, 2020

Codecov Report

Merging #281 into master will increase coverage by 0.38%.
The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #281      +/-   ##
==========================================
+ Coverage   89.11%   89.49%   +0.38%     
==========================================
  Files         140      140              
  Lines        6520     6518       -2     
==========================================
+ Hits         5810     5833      +23     
+ Misses        710      685      -25     
Impacted Files Coverage Δ
parts/boards/MiniRambo.h 100.00% <ø> (ø)
parts/printers/Prusa_MK2_13.cpp 98.51% <ø> (+11.10%) ⬆️
parts/printers/Prusa_MK2_13.h 100.00% <ø> (ø)
parts/boards/MiniRambo.cpp 97.93% <83.33%> (-2.07%) ⬇️
utility/GLObj.cpp 93.14% <100.00%> (-1.75%) ⬇️
utility/MK2_Full.cpp 100.00% <100.00%> (+1.02%) ⬆️
utility/MK3S_Bear.cpp 100.00% <100.00%> (+1.35%) ⬆️
utility/MK3S_Lite.cpp 100.00% <100.00%> (+1.51%) ⬆️
utility/MK3SGL.cpp 89.82% <0.00%> (-0.98%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db95120...2059a3f. Read the comment docs.

@vintagepc vintagepc merged commit 04fae8f into master Oct 31, 2020
@vintagepc vintagepc deleted the 280-enhance-printer-tests branch October 31, 2020 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IMPROVEMENT] - Shorten some of the graphics tests.
2 participants