Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not treat result parse exception as malformed #19

Merged

Conversation

buinauskas
Copy link
Collaborator

Type of PR

  • Documentation changes
  • Code changes
  • Test changes
  • CI-CD changes
  • GitHub Template changes

Purpose of PR

When a timeout happens, the feed client would raise a ResultParseException which inherits JsonParseException and this falls under the isMalformed condition. This can happen during upgrades or timeouts and it's not right to ignore such messages and skip them

Testing

  • Did you add testing to account for any new or changed work?

Review notes

Issues Closed or Referenced

  • Closes # (this will automatically close the issue when the PR closes)
  • References # (this references the issue but does not close with PR)

@buinauskas buinauskas merged commit af78cb2 into master Dec 18, 2023
2 checks passed
@buinauskas buinauskas deleted the feat/do_not_treat_result_parse_exception_as_malformed branch December 18, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants