Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration Cerberus #5

Merged
merged 49 commits into from
Aug 21, 2019
Merged

Integration Cerberus #5

merged 49 commits into from
Aug 21, 2019

Conversation

vipulgupta2048
Copy link
Owner

This PR marks the supposed ending of Cerberus's long journey into integration with its other pals.

Signed-off-by: Vipul Gupta (@vipulgupta2048) vipulgupta2048@gmail.com

@vipulgupta2048
Inital Commit
845d296 
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
@vipulgupta2048
Merge branch 'master' into cerberus
d0d251e
@vipulgupta2048
a
f541118 
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
@vipulgupta2048
Inital Commit
712978f 
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
ejulio
ejulio requested changes Jul 30, 2019
View reviewed changes
spidermon/contrib/scrapy/pipelines.py Outdated Show resolved Hide resolved
spidermon/contrib/scrapy/pipelines.py Outdated Show resolved Hide resolved
spidermon/contrib/scrapy/pipelines.py Show resolved Hide resolved
tests/contrib/scrapy/test_pipeline_cerberus.py Outdated Show resolved Hide resolved
tests/contrib/scrapy/test_pipeline_cerberus.py Outdated Show resolved Hide resolved
tests/contrib/scrapy/test_pipeline_cerberus.py Outdated Show resolved Hide resolved
@vipulgupta2048
Pruned Code/Comments + PEP8 + Black
e0ade7e 
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
@vipulgupta2048
Blacked Out
2a9f71d 
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
@vipulgupta2048
Add Cerberus in requirements
4cfaa67 
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
@vipulgupta2048
Add validation in Cerberus __init__
efd2bee 
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
@vipulgupta2048
Add JSONSchema to Utils for wider usage
51c1eea 
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
@vipulgupta2048
Review implemented as suggested
f437492 
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
@vipulgupta2048
Add Lambda
1420cd2 
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
@vipulgupta2048
Improvement
0d9860a 
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
ejulio
ejulio requested changes Aug 5, 2019
View reviewed changes
spidermon/contrib/scrapy/pipelines.py Show resolved Hide resolved
tests/contrib/scrapy/test_pipeline_cerberus.py Outdated Show resolved Hide resolved
tests/contrib/scrapy/test_pipeline_cerberus.py Outdated Show resolved Hide resolved
@vipulgupta2048
Changes made
f46a265 
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
@vipulgupta2048
Merge branch 'master' into cerberus
7143a95
@vipulgupta2048
Changes made
1156ac7 
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
@vipulgupta2048
Finish moving JSONSchema tools to Utils
022a948 
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
@vipulgupta2048
Tests work, URL Parse works
468d72b 
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
@vipulgupta2048
Pruning constants
877106b 
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
@vipulgupta2048
Pruning complete, fixing features
9a428ca 
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
@vipulgupta2048
Features fixed, testing now
80db826 
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
@vipulgupta2048
Testing OK
89509ba 
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
@vipulgupta2048
Final Prune
165ac5b 
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
vipulgupta2048
vipulgupta2048 commented Aug 12, 2019
View reviewed changes
Copy link
Owner Author

@vipulgupta2048 vipulgupta2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, here are new replies.

spidermon/contrib/scrapy/pipelines.py Show resolved Hide resolved
spidermon/contrib/monitors/mixins/validation.py Outdated Show resolved Hide resolved
spidermon/contrib/actions/email/__init__.py Outdated Show resolved Hide resolved
docs/source/conf.py Outdated Show resolved Hide resolved
@vipulgupta2048
Adding path tests
f43883b 
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
@vipulgupta2048
Merge branch 'master' into cerberus
a27b94a
@vipulgupta2048
Add URL, Path tests
a0eadca 
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
@vipulgupta2048
Fix black formatting for entire project
6672232 
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
@vipulgupta2048
Finish formating files left out
286a256 
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
@vipulgupta2048
Mocker Tests of CerberusValidator class
c3c374f 
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
@vipulgupta2048
Add mocker tests
3790418 
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
@vipulgupta2048
Black Formatted
ecaabb0 
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
vipulgupta2048
vipulgupta2048 commented Aug 16, 2019
View reviewed changes
Copy link
Owner Author

@vipulgupta2048 vipulgupta2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to go 🚀
Looking forward to any and all final changes suggested @rennerocha @ejulio
Let's bring this home.

ejulio
ejulio requested changes Aug 19, 2019
View reviewed changes
tests/contrib/scrapy/test_pipeline_cerberus.py Outdated Show resolved Hide resolved
tests/contrib/scrapy/test_pipeline_cerberus.py Outdated Show resolved Hide resolved
tests/contrib/scrapy/test_pipeline_cerberus.py Outdated Show resolved Hide resolved
tests/contrib/scrapy/test_pipeline_cerberus.py Outdated Show resolved Hide resolved
tests/contrib/scrapy/test_pipeline_cerberus.py Outdated Show resolved Hide resolved
@vipulgupta2048
Replaced is with ==
83628eb 
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
@vipulgupta2048
Add Autospec
2a2d372 
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
@vipulgupta2048
Fix tests, removed default true
46db6b5 
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
@vipulgupta2048
Black Formatted
c05d7f9 
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
@vipulgupta2048
Complete test_pipeline_cerberus
ea55a49 
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
@vipulgupta2048
Finish Commit
60f3def 
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
@vipulgupta2048
Removed unused import
c5ecd44 
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
@vipulgupta2048 @rennerocha
Spidermon x Cerberus Documentation (#6)
6325f48 
* Intial Cerberus docs

* Fix JSON schema

* Add functionality, deleted comments

Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>

* Final Changes

Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>

* Last final changes

Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>

* Fix Cerberus Schema

Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>

* Suggestions implemented as suggested

Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>

* Improve Docs

Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>

* Add indentation to code block

Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>

* Add Multiple Item example

Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>

* Add mention of Cerberus in L20

Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>

* Replace : with =

Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>

* Add ... as seperators

Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>

* Ready to go

Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>

* Example removed

Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
@vipulgupta2048
Add six.P2
5f29b42 
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
@vipulgupta2048
Merge branch 'cerberus' of https://github.com/vipulgupta2048/spidermon …
9dd4e70 
…into cerberus
@vipulgupta2048
Replace is --> ==
55ce6da 
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
@vipulgupta2048
Add helper function
b348bac 
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
@vipulgupta2048
Blacked
8a1075f 
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
ejulio
ejulio requested changes Aug 21, 2019
View reviewed changes
tests/contrib/scrapy/test_pipeline_cerberus.py Outdated Show resolved Hide resolved
tests/contrib/scrapy/test_pipeline_cerberus.py Outdated Show resolved Hide resolved
@vipulgupta2048
Changes made as suggested
c9fb74a 
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
@vipulgupta2048
.
11a2a87 
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
vipulgupta2048
vipulgupta2048 commented Aug 21, 2019
View reviewed changes
Copy link
Owner Author

@vipulgupta2048 vipulgupta2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, folks. I guess this is it.

@vipulgupta2048 vipulgupta2048 merged commit 3b80f34 into master Aug 21, 2019
@vipulgupta2048 vipulgupta2048 mentioned this pull request Aug 23, 2019
Closed
vipulgupta2048 added a commit that referenced this pull request Aug 30, 2019
@vipulgupta2048
Changes implemented as suggested #5
4614f26 
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejulio ejulio ejulio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vipulgupta2048 @ejulio