Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration Cerberus #5

Merged
merged 49 commits into from Aug 21, 2019

Conversation

@vipulgupta2048
Copy link
Owner

vipulgupta2048 commented Jul 21, 2019

This PR marks the supposed ending of Cerberus's long journey into integration with its other pals.

Signed-off-by: Vipul Gupta (@vipulgupta2048) vipulgupta2048@gmail.com

Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
a
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
spidermon/contrib/scrapy/pipelines.py Outdated Show resolved Hide resolved
spidermon/contrib/scrapy/pipelines.py Outdated Show resolved Hide resolved
spidermon/contrib/scrapy/pipelines.py Show resolved Hide resolved
tests/contrib/scrapy/test_pipeline_cerberus.py Outdated Show resolved Hide resolved
tests/contrib/scrapy/test_pipeline_cerberus.py Outdated Show resolved Hide resolved
tests/contrib/scrapy/test_pipeline_cerberus.py Outdated Show resolved Hide resolved
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
spidermon/contrib/scrapy/pipelines.py Show resolved Hide resolved
tests/contrib/scrapy/test_pipeline_cerberus.py Outdated Show resolved Hide resolved
tests/contrib/scrapy/test_pipeline_cerberus.py Outdated Show resolved Hide resolved
vipulgupta2048 added 10 commits Aug 6, 2019
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
Copy link
Owner Author

vipulgupta2048 left a comment

Hi, here are new replies.

spidermon/contrib/scrapy/pipelines.py Show resolved Hide resolved
spidermon/contrib/monitors/mixins/validation.py Outdated Show resolved Hide resolved
spidermon/contrib/actions/email/__init__.py Outdated Show resolved Hide resolved
docs/source/conf.py Outdated Show resolved Hide resolved
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
Copy link
Owner Author

vipulgupta2048 left a comment

Ready to go 🚀
Looking forward to any and all final changes suggested @rennerocha @ejulio
Let's bring this home.

tests/contrib/scrapy/test_pipeline_cerberus.py Outdated Show resolved Hide resolved
tests/contrib/scrapy/test_pipeline_cerberus.py Outdated Show resolved Hide resolved
tests/contrib/scrapy/test_pipeline_cerberus.py Outdated Show resolved Hide resolved
tests/contrib/scrapy/test_pipeline_cerberus.py Outdated Show resolved Hide resolved
tests/contrib/scrapy/test_pipeline_cerberus.py Outdated Show resolved Hide resolved
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
* Intial Cerberus docs

* Fix JSON schema

* Add functionality, deleted comments

Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>

* Final Changes

Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>

* Last final changes

Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>

* Fix Cerberus Schema

Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>

* Suggestions implemented as suggested

Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>

* Improve Docs

Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>

* Add indentation to code block

Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>

* Add Multiple Item example

Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>

* Add mention of Cerberus in L20

Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>

* Replace : with =

Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>

* Add ... as seperators

Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>

* Ready to go

Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>

* Example removed

Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
tests/contrib/scrapy/test_pipeline_cerberus.py Outdated Show resolved Hide resolved
tests/contrib/scrapy/test_pipeline_cerberus.py Outdated Show resolved Hide resolved
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
.
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
@ejulio
ejulio approved these changes Aug 21, 2019
Copy link
Owner Author

vipulgupta2048 left a comment

Well, folks. I guess this is it.

@vipulgupta2048 vipulgupta2048 merged commit 3b80f34 into master Aug 21, 2019
vipulgupta2048 added a commit that referenced this pull request Aug 30, 2019
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.