Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v2] vrmManagers to class #16

Closed
yamayuski opened this issue Jun 11, 2019 · 1 comment
Closed

[v2] vrmManagers to class #16

yamayuski opened this issue Jun 11, 2019 · 1 comment
Labels
v3 BREAKING CHANGE issues
Milestone
v3

Comments

@yamayuski
Copy link
Contributor

yamayuski commented Jun 11, 2019 •
edited
Loading

BREAKING CHANGE

scene.metadata.vrmManagers: VRMManager[] to scene.metadata.vrmManagers: VRMManagers

interface VRMManagers {
  getByName(name: string): Nullable<VRMManager>;
  getByIndex(index: number): Nullable<VRMManager>;
  updateAll(): Promise<void>;
}

Instead, SceneLoader.LoadAssetContainer based loading is preferred?

https://doc.babylonjs.com/how_to/load_from_any_file_type#sceneloaderloadassetcontainer
@yamayuski yamayuski added the v3 BREAKING CHANGE issues label Jun 11, 2019
@yamayuski yamayuski mentioned this issue Jul 1, 2019
Open
@yamayuski yamayuski added this to the v2 milestone Mar 22, 2022
@yamayuski
Copy link
Contributor Author

yamayuski pushed a commit to yamayuski/babylon-vrm-loader that referenced this issue Oct 23, 2023
@il-masaru-yamagishi
Merge pull request virtual-cast#16 from virtual-cast/il-m-yamagishi-p…
02a2ac1 
…atch-1

fix(VertexShader): Fixed invalid worldPos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v3 BREAKING CHANGE issues
Projects
None yet
Milestone
v3
Development

No branches or pull requests
1 participant
@yamayuski