Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer to use with SceneLoader.LoadAssetContainer #28

Open
Tracked by #104
yamayuski opened this issue Jul 1, 2019 · 0 comments
Open
Tracked by #104

Prefer to use with SceneLoader.LoadAssetContainer #28

yamayuski opened this issue Jul 1, 2019 · 0 comments
Labels
enhancement New feature or request v3 BREAKING CHANGE issues
Milestone

Comments

@yamayuski
Copy link
Contributor

yamayuski commented Jul 1, 2019

現在 glTFLoader の読み込み完了後に scene.metadata.vrmManagers にマネージャを代入しているが、使い勝手が悪い。

SceneLoader.LoadAssetContainer を利用してアセットコンテナオブジェクトをコンストラクタに渡し、ユーザランドで VRMManager の管理を出来るようにした方が良い。

interface VRMContainer {
  public constructor(public readonly assetContainer: AssetContainer): void;
  public get humanoidBone(): HumanoidBone;
  public get blendShape(): BlendShape;
  public get firstPerson(): FirstPerson;
  public get meta(): Meta;
  public get inScene(): boolean;
  public addToScene(): void;
  public removeFromScene(): void;
  public update(deltaTime: number): Promise<void>;
  public dispose();
}

ref #16

https://doc.babylonjs.com/how_to/load_from_any_file_type#sceneloaderloadassetcontainer

AssetsManager を利用しても問題なく使えるか確認が必要 https://doc.babylonjs.com/how_to/how_to_use_assetsmanager

現状 gltf json を読み込む場所がないので、 vrm_extension で scene.metadata[loadName].vrm などにエクスポートする必要がありそう

@yamayuski yamayuski added the v3 BREAKING CHANGE issues label Jul 1, 2019
@yamayuski yamayuski changed the title [v2] Prefer Use with SceneLoader.LoadAssetContainer Prefer Use with SceneLoader.LoadAssetContainer Jul 1, 2019
@yamayuski yamayuski added the enhancement New feature or request label Jul 1, 2019
@yamayuski yamayuski changed the title Prefer Use with SceneLoader.LoadAssetContainer Prefer to Use with SceneLoader.LoadAssetContainer Jul 2, 2019
@yamayuski yamayuski changed the title Prefer to Use with SceneLoader.LoadAssetContainer Prefer to use with SceneLoader.LoadAssetContainer Jul 2, 2019
@yamayuski yamayuski added this to the v2 milestone Mar 22, 2022
@yamayuski yamayuski mentioned this issue Jun 12, 2023
6 tasks
yamayuski pushed a commit to yamayuski/babylon-vrm-loader that referenced this issue Oct 23, 2023
fix(FragmentShader): Fix invalid alpha although it is opaque
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v3 BREAKING CHANGE issues
Projects
None yet
Development

No branches or pull requests

1 participant