Merge pull request #877 from sgfost/fix-connection-failure

use pRetry to retry failed db connections on application startup
virtualcommons · Jul 27, 2023 · 08e86cf · 08e86cf
2 parents ac44b5c + 5fa4fce
commit 08e86cf
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 4 deletions.
diff --git a/server/package.json b/server/package.json
@@ -97,6 +97,7 @@
     "node-schedule": "^1.3.2",
     "nodemailer": "^6.6.0",
     "nodemailer-mailgun-transport": "^2.1.3",
+    "p-retry": "4",
     "passport": "^0.6.0",
     "passport-facebook": "^3.0.0",
     "passport-google-oauth20": "^2.0.0",

diff --git a/server/src/index.ts b/server/src/index.ts
@@ -6,6 +6,7 @@ import cookieParser from "cookie-parser";
 import cors from "cors";
 import session from "express-session";
 import connectRedis from "connect-redis";
+import pRetry from "p-retry";
 import * as Sentry from "@sentry/node";
 import { Server } from "colyseus";
 import schedule from "node-schedule";
@@ -226,8 +227,18 @@ async function createApp() {
   });
 }
 
-createConnection(CONNECTION_NAME)
-  .then(async connection => {
+// connect to the database and start the server, retrying if the connection fails
+pRetry(
+  async () => {
+    await createConnection(CONNECTION_NAME);
     await createApp();
-  })
-  .catch(error => logger.fatal(error));
+  },
+  {
+    onFailedAttempt: error => {
+      logger.warn(`Connection to db failed on attempt number ${error.attemptNumber}, retrying...`);
+    },
+    retries: 10,
+    minTimeout: 1 * 1000,
+    maxTimeout: 60 * 1000,
+  }
+).catch(error => logger.fatal(error));
diff --git a/server/yarn.lock b/server/yarn.lock
@@ -1197,6 +1197,11 @@
   dependencies:
     "@types/node" "*"
 
+"@types/retry@0.12.0":
+  version "0.12.0"
+  resolved "https://registry.yarnpkg.com/@types/retry/-/retry-0.12.0.tgz#2b35eccfcee7d38cd72ad99232fbd58bffb3c84d"
+  integrity sha512-wWKOClTTiizcZhXnPY4wikVAwmdYHp8q6DmC+EJUzAMsycb7HB32Kh9RN4+0gExjmPmZSAQjgURXIGATPegAvA==
+
 "@types/semver@^7.3.12":
   version "7.5.0"
   resolved "https://registry.yarnpkg.com/@types/semver/-/semver-7.5.0.tgz#591c1ce3a702c45ee15f47a42ade72c2fd78978a"
@@ -4093,6 +4098,14 @@ p-locate@^4.1.0:
   dependencies:
     p-limit "^2.2.0"
 
+p-retry@4:
+  version "4.6.2"
+  resolved "https://registry.yarnpkg.com/p-retry/-/p-retry-4.6.2.tgz#9baae7184057edd4e17231cee04264106e092a16"
+  integrity sha512-312Id396EbJdvRONlngUx0NydfrIQ5lsYu0znKVUzVvArzEIt08V1qhtyESbGVd1FGX7UKtiFp5uwKZdM8wIuQ==
+  dependencies:
+    "@types/retry" "0.12.0"
+    retry "^0.13.1"
+
 p-try@^2.0.0:
   version "2.2.0"
   resolved "https://registry.yarnpkg.com/p-try/-/p-try-2.2.0.tgz#cb2868540e313d61de58fafbe35ce9004d5540e6"
@@ -4676,6 +4689,11 @@ resolve@^1.0.0, resolve@^1.1.6, resolve@^1.20.0:
     path-parse "^1.0.7"
     supports-preserve-symlinks-flag "^1.0.0"
 
+retry@^0.13.1:
+  version "0.13.1"
+  resolved "https://registry.yarnpkg.com/retry/-/retry-0.13.1.tgz#185b1587acf67919d63b357349e03537b2484658"
+  integrity sha512-XQBQ3I8W1Cge0Seh+6gjj03LbmRFWuoszgK9ooCpwYIrhhoO80pfq4cUkU5DkknwfOfFteRwlZ56PYOGYyFWdg==
+
 reusify@^1.0.4:
   version "1.0.4"
   resolved "https://registry.yarnpkg.com/reusify/-/reusify-1.0.4.tgz#90da382b1e126efc02146e90845a88db12925d76"