Solo Game #881
Closed
Solo Game #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: saachibm <saachibm@users.noreply.github.com> Co-authored-by: sabrinanel3 <sabrinanel3@users.noreply.github.com> Co-authored-by: sgfost <sgfost@users.noreply.github.com>
Co-authored-by: sabrinanel3 <sabrinanel3@users.noreply.github.com>
Co-authored-by: sabrinanel3 <sabrinanel3@users.noreply.github.com>
Co-authored-by: sabrinanel3 <sabrinanel3@users.noreply.github.com>
…k card entities refactor: minor changes to solo game treatment Co-authored-by: sabrinanel3 <sabrinanel3@users.noreply.github.com>
TODO: - implement service layer for persistence, recovery(?), and retrieval ref virtualcommons#856
caused a loop that wouldn't let the container start up properly, yarn install is ran from the Dockerfile
- minor renaming - add types - fix issues/refactor in the game logic commands
state is currently local to the component, we should reorganize the single vuex store we have currently (split up game and anything else) and then add a new SoloGame store
add solo game db model
- add fixtures for game treatments and event cards - add service methods for persisting game data and drawing cards/picking treatments - reworked solo game entities - (re-)add migration for solo game data model ref virtualcommons#856
add link to nav bar, which should probably have a better name
Co-authored-by: sgfost <sgfost@users.noreply.github.com>
finalization (updatePlayerPoints) would throw an error since gameId was not set on the solo_player
Co-authored-by: sgfost <sgfost@users.noreply.github.com>
Co-authored-by: sabrinanel3 <sabrinanel3@users.noreply.github.com> Co-authored-by: Tiffany Kawamura <Tkawamura02@users.noreply.github.com>
by setting activeRoundCardIndex to -1
Co-authored-by: sabrinanel3 <sabrinanel3@users.noreply.github.com> Co-authored-by: Tiffany Kawamura <Tkawamura02@users.noreply.github.com>
layout should enforce max sizes for individual components to prevent ones with more content from flexing too much
- fix DSEG font Co-authored-by: Tiffany Kawamura <Tkawamura02@users.noreply.github.com>
server waits a few seconds after investment before setting up a new round and the client now has access to `isRoundTransitioning` when this is taking place ref virtualcommons#882
run with `make test-server tests="sologame"`
- correct the logic for selecting 'played' treatments - select treatments from the available 12 instead of creating new ones - persist round in a seperate command before either setting a new round or ending a game to ensure the last round gets persisted correctly
…nts' are not shown
needed to clear the clock timeout
missing metadata needed for normalizing scores/analysis [no ci]
- for the first 12 treatments, go in order - correctly store max round when creating a game - display 0 points in the gameover screen for a defeat - always show 0 in the number display component when the value is 0
|
superseded by #895 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the implementation of a solo game mode as described in #856
TODO: