Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes to concept generators #1152

Merged

Conversation

franzTobiasDLR
Copy link
Member

@franzTobiasDLR franzTobiasDLR commented Aug 18, 2023

Closes #879
Closes #1130

Updates the concept generator:

  • Add server depenencies to new concept proejcts
  • Update package location of SEIValidator
  • Add java 11 automatic module header (we had a warning before)
  • Changed way how the main-project name is derived from test & ui projects... before all 'ui' and 'test' strings were simply replaced... This was quite problemativ because it caused errors when the concept hat something with 'test' / 'ui' in its name
  • Do a workspace refresh after generation is compelted to make sure icons are shown in the project explorer (also there we had a warning before that icons could not be found although they were generated)

No new concept project do not have warnings anymore. :)

@franzTobiasDLR franzTobiasDLR linked an issue Aug 18, 2023 that may be closed by this pull request
3 tasks
@franzTobiasDLR franzTobiasDLR self-assigned this Aug 18, 2023
@franzTobiasDLR franzTobiasDLR added bug Something isn't working quality Code Quality improvement concept IDE This affects the Concept IDE Server Related to rest API and Virtual Satellite Server labels Aug 18, 2023
@franzTobiasDLR franzTobiasDLR added this to the Release 4.16.0 milestone Aug 18, 2023
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #1152 (e9f1dac) into development (8d4f3f1) will decrease coverage by 0.05%.
The diff coverage is 75.00%.

❗ Current head e9f1dac differs from pull request most recent head 407216b. Consider uploading reports for the commit 407216b to get more accurate results

Impacted file tree graph

@@                Coverage Diff                @@
##             development    #1152      +/-   ##
=================================================
- Coverage          86.87%   86.83%   -0.05%     
+ Complexity          5146     5144       -2     
=================================================
  Files                629      629              
  Lines              25632    25657      +25     
  Branches            2330     2331       +1     
=================================================
+ Hits               22267    22278      +11     
- Misses              2580     2594      +14     
  Partials             785      785              
Files Changed Coverage Δ
...el/concept/generator/ConceptLanguageGenerator.java 0.00% <0.00%> (ø)
...concept/generator/validator/GenerateValidator.java 94.44% <100.00%> (ø)
...econtent/ConceptFragmentTestManifestGenerator.java 100.00% <100.00%> (ø)
...ct/filecontent/ConceptPluginManifestGenerator.java 100.00% <100.00%> (ø)
.../filecontent/ConceptPluginUiManifestGenerator.java 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@franzTobiasDLR franzTobiasDLR merged commit f3ba3c6 into development Aug 18, 2023
This was referenced Aug 30, 2023
@PhilMFischer PhilMFischer deleted the feature/879-minor-fixes-to-concept-generators branch August 5, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working concept IDE This affects the Concept IDE quality Code Quality improvement Server Related to rest API and Virtual Satellite Server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New concept plugins are generated with missing dependencies Minor fixes to concept generators
3 participants