Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve data access via virtual satellite headless #1175

Conversation

franzTobiasDLR
Copy link
Member

In this PR, we imrpove the generall usage and data access of our Virtual Satellite Headless Server.

Includes

  • Enable customization of Port (and prints activated port)
  • Return new objects instead of only their UUID on POST requests
  • Improves error response if user does not have rights to modify data model (as specified in the Rolemanagement)

@franzTobiasDLR franzTobiasDLR linked an issue Jan 25, 2024 that may be closed by this pull request
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Merging #1175 (176fbab) into development (8027909) will decrease coverage by 0.11%.
The diff coverage is 64.51%.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             development    #1175      +/-   ##
=================================================
- Coverage          86.90%   86.79%   -0.11%     
+ Complexity          5147     5145       -2     
=================================================
  Files                629      629              
  Lines              25659    25681      +22     
  Branches            2331     2333       +2     
=================================================
- Hits               22298    22290       -8     
- Misses              2578     2606      +28     
- Partials             783      785       +2     
Files Coverage Δ
...dlr/sc/virsat/server/resources/ApiErrorHelper.java 90.00% <100.00%> (ø)
...c/virsat/server/resources/ModelAccessResource.java 82.69% <100.00%> (ø)
...ources/modelaccess/CategoryAssignmentResource.java 81.81% <100.00%> (-7.66%) ⬇️
...modelaccess/StructuralElementInstanceResource.java 78.94% <100.00%> (-9.29%) ⬇️
.../dlr/sc/virsat/server/VirSatServerApplication.java 0.00% <0.00%> (ø)
.../dlr/sc/virsat/server/jetty/VirSatJettyServer.java 81.57% <27.27%> (-9.47%) ⬇️

... and 2 files with indirect coverage changes

@franzTobiasDLR franzTobiasDLR changed the title WIP: Improve data access via virtual satellite headless Improve data access via virtual satellite headless Mar 25, 2024
@franzTobiasDLR franzTobiasDLR self-assigned this Mar 25, 2024
@franzTobiasDLR franzTobiasDLR added the Server Related to rest API and Virtual Satellite Server label Mar 25, 2024
@franzTobiasDLR franzTobiasDLR added this to the Release 4.17.0 milestone Mar 25, 2024
@dellerDLR dellerDLR merged commit 098b139 into development Jul 31, 2024
13 of 14 checks passed
@PhilMFischer PhilMFischer deleted the feature/1174-improve-data-access-of-virtual-satellite-headless branch August 5, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Server Related to rest API and Virtual Satellite Server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve data access of Virtual Satellite Headless
3 participants