Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add volta section to package.json on 8.10-release branch. #8220

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Oct 23, 2023

Background

  • if the developer has installed volta locally, it will ensure that the versions of yarn and node that are specified in the package.json volta section are used. Otherwise this section is ignored.
  • this can save time when returning to a repo after some hiatus, as it is very clear what node and yarn versions are expected to work.
  • volta sections have been added to most frameworks including deck.gl master.

Change List

  • Add volta section to package.json

package.json Outdated
Comment on lines 53 to 54
"@loaders.gl/csv": "4.0.0-beta.6",
"@loaders.gl/polyfills": "4.0.0-beta.6",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably unintentional to update loaders?

Comment on lines +85 to +86
"node": "18.18.2",
"yarn": "1.22.19"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been using node 16. Could we use master's versions?

  "volta": {
    "node": "16.19.1",
    "yarn": "1.22.19"
  }

Copy link
Collaborator Author

@ibgreen ibgreen Oct 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps. Though Node 16 is no longer a supported version of Node.js. Works well with Node 18 and loaders.gl is also focused on Node 18. In addition it won't affect your usage unless you are using volta.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll make a PR to update deck to 18 where its currently using 16.

@chrisgervang chrisgervang mentioned this pull request Oct 23, 2023
@ibgreen ibgreen marked this pull request as ready for review October 23, 2023 22:55
@ibgreen ibgreen merged commit df90f0d into 8.10-release Oct 23, 2023
3 checks passed
@ibgreen ibgreen deleted the ib/volta branch October 24, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants