Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update version build comments #8904

Merged
merged 2 commits into from
May 20, 2024
Merged

chore: update version build comments #8904

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0be76b3
chore: update version build comments
chrisgervang May 19, 2024
25feb31
Merge branch 'master' into chr/bundle-comments
chrisgervang May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modules/core/src/lib/init.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ declare global {
}

function checkVersion() {
// Version detection using babel plugin
// Fallback for tests and SSR since global variable is defined by Webpack.
// Version detection using typescript plugin.
// Fallback for tests and SSR since global variable is defined by esbuild.
const version =
typeof __VERSION__ !== 'undefined'
? __VERSION__
Expand Down
Loading