-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Use Popup in Maplibre/Mapbox getting started example #8956
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the mapbox example be updated as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely a more useful example this way. Though, I'm not sure I understand your comment about reverse-control since this isn't that. Those examples are all in website
whereas this is considered to be using the overlay pattern.
@chrisgervang what I was getting at regarding "reverse-controlled" is that newcomers will look at our examples (get-started or website) and pick whatever looks most appropriate, not realizing that they've chosen an integration mode. Then when it comes to adding a Popup, they might get stuck if they "accidentally" picked a reverse-controlled pattern. |
Closes #8530
Background
This is a common use case and it isn't trivial as it isn't obvious that it isn't possible to do this with the "reverse-controlled" React pattern.
Change List
Popup
component instead ofalert()