Merge pull request #539 from mclotworthy/master

Remove Regex "matched text"
visionmedia · May 29, 2019 · 7f8e01d · 7f8e01d
2 parents aee9de8 + f2ce742
commit 7f8e01d
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/page.js b/page.js
@@ -1189,6 +1189,8 @@ pathToRegexp_1.tokensToRegExp = tokensToRegExp_1;
       m = this.regexp.exec(decodeURIComponent(pathname));
 
     if (!m) return false;
+
+    delete params[0]
 
     for (var i = 1, len = m.length; i < len; ++i) {
       var key = keys[i - 1];

diff --git a/test/tests.js b/test/tests.js
@@ -422,6 +422,14 @@
           });
           page('/ctxparams/test/');
         });
+
+        it('should handle optional first param', function(done) {
+          page(/^\/ctxparams\/(option1|option2)?$/, function(ctx) {
+            expect(ctx.params[0]).to.be.undefined;
+            done();
+          });
+          page('/ctxparams/');
+        });
       });
 
       describe('ctx.handled', function() {