Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimizeIterable doesn't work with SharedArrayBuffer #103

Closed
RebeccaStevens opened this issue Dec 30, 2021 · 7 comments · Fixed by #165
Closed

optimizeIterable doesn't work with SharedArrayBuffer #103

RebeccaStevens opened this issue Dec 30, 2021 · 7 comments · Fixed by #165
Labels
needs investigation

Comments

@RebeccaStevens
Copy link
Collaborator

ArrayBuffer work but not SharedArrayBuffer.
RebeccaStevens added a commit to RebeccaStevens/iter-ops that referenced this issue Dec 30, 2021
@RebeccaStevens
fix: isIndexed didn't have support for SharedArrayBuffer
337d834 
fix vitaly-t#103
@RebeccaStevens
Copy link
Collaborator Author

RebeccaStevens commented Dec 30, 2021 •
edited
Loading

Fixed here but this relies on #96 so I'll open a PR for it once that is merged.

@vitaly-t
Copy link
Owner

vitaly-t commented Dec 30, 2021 •
edited
Loading

I'm parking it here, for now, will return after New Year.

Happy New Year! 🎄

@RebeccaStevens
Copy link
Collaborator Author

You too

@vitaly-t
Copy link
Owner

@RebeccaStevens
This needs to be re-visited 😉

@vitaly-t vitaly-t mentioned this issue Oct 12, 2022
Closed
@vitaly-t
Copy link
Owner

@RebeccaStevens Can we add the fix, please, if it is not there yet?

@vitaly-t vitaly-t mentioned this issue Oct 15, 2022
Closed
RebeccaStevens added a commit that referenced this issue Oct 16, 2022
@RebeccaStevens
fix: handling of SharedArrayBuffer
ed93394 
fix #103
@RebeccaStevens RebeccaStevens mentioned this issue Oct 16, 2022
Merged
@RebeccaStevens
Copy link
Collaborator Author

PR opened

@vitaly-t
Copy link
Owner

vitaly-t commented Oct 16, 2022 •
edited
Loading

Thank you!!!! 👍 Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs investigation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: handling of SharedArrayBuffer vitaly-t/iter-ops
2 participants
@vitaly-t @RebeccaStevens