Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve onEnd details #161

Closed
vitaly-t opened this issue Oct 15, 2022 · 2 comments
Closed

Improve onEnd details #161

vitaly-t opened this issue Oct 15, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@vitaly-t
Copy link
Owner

vitaly-t commented Oct 15, 2022

Operator onEnd can be improved with extra details about duration, by providing min/max duration, along with indexes of where those were reached.

This is to help locate deviations in iterable performance.

For example, have duration inside IIterationSummary of the following type:

export interface IDuration {
    average: number; // averge duration
    max?: {delay, index, value} // delay = waiting time, index when the value was reached, the value
    min?: {delay, index, value}; // same as above
    total: number; // total duration
}

This would be a breaking change, because duration property changes.

@vitaly-t vitaly-t added the enhancement New feature or request label Oct 15, 2022
vitaly-t added a commit that referenced this issue Oct 15, 2022
vitaly-t added a commit that referenced this issue Oct 15, 2022
vitaly-t added a commit that referenced this issue Oct 15, 2022
@vitaly-t
Copy link
Owner Author

This change now has been merged into master.

@vitaly-t
Copy link
Owner Author

Updated onEnd released in v2.0.0-beta.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant