Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipeSync should throw an error on any asynchronous input #177

Closed
vitaly-t opened this issue Nov 1, 2022 · 0 comments · Fixed by #184
Closed

pipeSync should throw an error on any asynchronous input #177

vitaly-t opened this issue Nov 1, 2022 · 0 comments · Fixed by #184
Assignees
Labels
done Feature has been implemented enhancement New feature or request

Comments

@vitaly-t
Copy link
Owner

vitaly-t commented Nov 1, 2022

When pipeSync is called explicitly by the client, and passed an asynchronous iterable, it should throw an error:

TypeError(`A synchronous iterable was expected: ${JSON.stringify(input)`)

...because this represents an implementation error.

Presently, the input type is only controlled at compile time, and the function erroneously produces an asynchronous output.


@RebeccaStevens I'm assigning this to yourself, if you want to have more fun with this library ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done Feature has been implemented enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants