Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support "base" path from vite config #4

Closed
ubermanu opened this issue Dec 6, 2020 · 2 comments
Closed

Support "base" path from vite config #4

ubermanu opened this issue Dec 6, 2020 · 2 comments

Comments

@ubermanu
Copy link

ubermanu commented Dec 6, 2020

Hey,

When building static assets from VitePWA, the paths to the service worker and the manifest is hardcoded (at root level)
Would it be possible to preprend them with the "base" config from vite?
@antfu
Copy link
Member

antfu commented Dec 22, 2020

Would you mind to open a PR for it? Thanks.

hannoeru added a commit to hannoeru/vite-plugin-pwa that referenced this issue Jan 12, 2021
@hannoeru
fix: service worker register path & use build base (vite-pwa#4)
1a75b2e
@hannoeru hannoeru mentioned this issue Jan 12, 2021
Merged
antfu pushed a commit that referenced this issue Jan 12, 2021
@hannoeru
fix: service worker register path & use config build base (#4) (#13)
a7bbbc2 
* chore: update

* fix: service worker register path & use build base (#4)

* test: add build base in example
@antfu
Copy link
Member

antfu commented Jan 16, 2021

#13

@antfu antfu closed this as completed Jan 16, 2021
@eLvErDe eLvErDe mentioned this issue Feb 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ubermanu @antfu