fix(rsc): inject AsyncLocalStorage global via transform
#785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hi-ogawa
commented
Aug 27, 2025
Comment on lines
+962
to
+969
| // for build, we cannot use `import` as it confuses rollup commonjs plugin. | ||
| return ( | ||
| (this.environment.mode === 'build' && !isRolldownVite | ||
| ? `const __viteRscAyncHooks = require("node:async_hooks");` | ||
| : `import * as __viteRscAyncHooks from "node:async_hooks";`) + | ||
| `globalThis.AsyncLocalStorage = __viteRscAyncHooks.AsyncLocalStorage;` + | ||
| code | ||
| ) |
There was a problem hiding this comment.
Sadly, it feels as hacky as before, but probably alright.
There was a problem hiding this comment.
Hey, maybe you'd like to be warned about a little typo : __viteRscAyncHooks (should probably be __viteRscAsyncHooks)
There was a problem hiding this comment.
Aha, good catch. PR welcome :)
hi-ogawa
commented
Aug 27, 2025
hi-ogawa
deleted the
08-27-fix_rsc_inject_asynclocalstorage_global_via_transform
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AsyncLocalStorageproperly on non runnable environment #784In old days, we have externalized react on
ssrenvironment, so it's not possible to inject through transform, but now it's possible.