Skip to content

chore(rsc): add web-streams-polyfill to browser-mode example on webkit #807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+17 −3
Closed

chore(rsc): add web-streams-polyfill to browser-mode example on webkit #807

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/plugin-rsc/e2e/browser-mode.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { defineStarterTest } from './starter'
test.describe('dev-browser-mode', () => {
// Webkit fails by
// > TypeError: ReadableByteStreamController is not implemented
test.skip(({ browserName }) => browserName === 'webkit')
// test.skip(({ browserName }) => browserName === 'webkit')

const f = useFixture({ root: 'examples/browser-mode', mode: 'dev' })
defineStarterTest(f, 'browser-mode')
Expand Down
6 changes: 5 additions & 1 deletion packages/plugin-rsc/examples/browser-mode/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,13 @@
<title>RSC Browser Mode</title>
<meta name="viewport" content="width=device-width, initial-scale=1" />
<link rel="icon" type="image/svg+xml" href="/vite.svg" />
<script async type="module" src="/src/framework/main.tsx"></script>
<!-- <script async type="module" src="/src/framework/main.tsx"></script> -->
</head>
<body>
<div id="root"></div>
<script type="module">
await import('./node_modules/web-streams-polyfill/dist/polyfill.js')
await import('./src/framework/main.tsx')
</script>
</body>
</html>
3 changes: 2 additions & 1 deletion packages/plugin-rsc/examples/browser-mode/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
"@types/react-dom": "^19.1.8",
"@vitejs/plugin-react": "latest",
"@vitejs/plugin-rsc": "latest",
"vite": "^7.1.3"
"vite": "^7.1.3",
"web-streams-polyfill": "^4.2.0"
}
}
9 changes: 9 additions & 0 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading