Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(css): missing css in lib mode #10185

Merged
merged 3 commits into from
Sep 25, 2022
Merged

fix(css): missing css in lib mode #10185

merged 3 commits into from
Sep 25, 2022

Conversation

Dunqing
Copy link
Contributor

@Dunqing Dunqing commented Sep 21, 2022

Description

fix: #10137

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Dunqing Dunqing changed the title fix(css): do not inject css in lib mode fix(css): missing css in lib mode Sep 22, 2022
bluwy
bluwy reviewed Sep 23, 2022
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a regression of #9761

@bluwy bluwy merged commit e4c1c6d into vitejs:main Sep 25, 2022
@bluwy
Copy link
Member

bluwy commented Sep 25, 2022

Thanks!

@Jaydwg
Copy link

Jaydwg commented Sep 25, 2022

ok

@Dunqing Dunqing mentioned this pull request Sep 27, 2022
Closed
antfu pushed a commit that referenced this pull request Oct 6, 2022
@Dunqing @antfu
fix(css): missing css in lib mode (#10185)
e2cdb28
@sapphi-red sapphi-red mentioned this pull request Oct 17, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapphi-red sapphi-red sapphi-red approved these changes

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

css is not part of the bundle with option cssCodeSplit since 3.1.0
4 participants
@Dunqing @bluwy @Jaydwg @sapphi-red