perf: avoid execSync on openBrowser #12510
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
openBrowser
was blocking the node thread in OSX, this PR saves a bit of time by usingexec
instead. We don't really use the return value ofopenBrowser
.On M1, I'm getting ~200ms faster start after this PR
If
--open
is used, frameworks could trigger atransformRequest
of the app entry point so the modules are already pre-processed when the browser finally opens and starts to request them. We could also try to add a cache totransformIndexHtml
so we start right away for apps that have anindex.html
by default.@ArnaudBarre could you check this, maybe there was another reason to make these sync.
What is the purpose of this pull request?