fix: open browser reuse logic #12535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ArnaudBarre
reviewed
Mar 22, 2023
Comment on lines
104
to
108
| return true | ||
| } | ||
| } catch (err) { | ||
| // Ignore errors | ||
| } |
There was a problem hiding this comment.
IMO the try catch before felt more natural
} else {
crossPlatformStart()
}
} catch (err) {
crossPlatformStart()
}There was a problem hiding this comment.
We can no longer use a catch here except if we create an execAsync wrapper, no?
There was a problem hiding this comment.
Oh yeah true exec is not promise based... 🙈
There was a problem hiding this comment.
I sort of feel like an execAsync wrapper would be easier to read too, since this isn't hot code we could use async..await here
ArnaudBarre
previously approved these changes
Mar 22, 2023
ArnaudBarre
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@bluwy @ArnaudBarre we merged #12510 too quickly 😅
What is the purpose of this pull request?