create-vite issue of prompts after scaffolding project

[ghost]

Describe the bug

Hi team, when I create a vite project inside a folder and input project name with current directory ./.

✔ Project name:  ./

I got prompts after scaffolding project as below:

Done. Now run:

  cd 
  npm install
  npm run dev

I checked packages/create-vite and found the reason at line 266:

if (root !== cwd) {}

I think the condition here needs to be:

if (path.relative(cwd, root)) {}

In this way, when typing ./ is still make sense. If this is a bug, I can raise a PR to fix it.

Reproduction

https://telegra.ph/create-vite-issue-of-prompts-after-scaffolding-project-02-13

System Info

System:
  OS: macOS 12.2
  CPU: (8) x64 Apple M1
  Memory: 390.95 MB / 16.00 GB
  Shell: 3.3.1 - /usr/local/bin/fish
Binaries:
  Node: 17.4.0 - /usr/local/bin/node
  Yarn: 1.22.17 - /usr/local/bin/yarn
  npm: 8.4.1 - /usr/local/bin/npm
Browsers:
  Chrome: 98.0.4758.80
  Safari: 15.3

Used Package Manager

npm

Logs

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/core instead.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[bluwy]

Maybe we should use path.resolve here instead?

vite/packages/create-vite/index.js

Line 225 in 62cbe68

const root = path.join(cwd, targetDir)

It looks like using path.join and ./, the root would be something like /foo/bar/my-project/ (with a trailing slash), while using path.resolve doesn't have the trailing slash.

Feel free to test it out and make a PR though. I think this is a minor bug.

[Olyno]

Hi 👋🏻
Looks like it was a mistake from me. I did a pr to fix that. Thanks you for the report!