fix: externalize workspace relative import when bundle config #9140
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes failing sveltekit test in ecosystem-ci.
Additional context
The issue is that in this config file. It's importing
../../utils.js
, which imports from another workspace package (kit
). If we bundle the files and leave bare imports externalized, the bundled code can't import deps from that other workspace package, leading to a runtime error.This PR makes sure that for files in another package, we should externalize them so that they can require the deps themselves. However, this may regress the second workaround for #5370 if the file from another package doesn't import anything, but I don't think that it's good to allow it in the first place (?).
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).