Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: start preprocessing static imports before updating module graph #12723

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

patak-dev
Copy link
Member

@patak-dev patak-dev commented Apr 3, 2023

Description

Done with @antfu by my side 😄

We are seeing in https://github.com/sapphi-red/performance-compare, a reduction from ~1650ms to ~1350ms on M1

We still need to think about the implications, but this may be a reason why the warmup plugin from @bluwy was having such a big effect. We could see if we could even start it before.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@stackblitz
Copy link

stackblitz bot commented Apr 3, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev
Copy link
Member Author

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

vite-ecosystem-ci bot commented Apr 3, 2023

📝 Ran ecosystem CI: Open

suite result
astro ✅ success
histoire ❌ failure
iles ✅ success
ladle ✅ success
laravel ✅ success
marko ✅ success
nuxt ❌ failure
previewjs ❌ failure
qwik ✅ success
rakkas ✅ success
sveltekit ✅ success
vite-plugin-ssr ❌ failure
vite-plugin-react ✅ success
vite-plugin-react-pages ✅ success
vite-plugin-react-swc ✅ success
vite-plugin-svelte ❌ failure
vite-plugin-vue ✅ success
vite-setup-catalogue ✅ success
vitepress ✅ success
vitest ✅ success
windicss ✅ success

@patak-dev patak-dev requested a review from bluwy April 3, 2023 14:56
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why I didn't spot this optimization, makes sense 🚀

@patak-dev patak-dev merged commit c90b46e into main Apr 3, 2023
@patak-dev patak-dev deleted the perf/start-pre-processing-static-imports-earlier branch April 3, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants