Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add SvelteKit to the Environment API story #18877

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

patak-dev
Copy link
Member

Description

This is how I started the story in my ViteConf talk but we didn't have a direct shoutout in the blog post. We saw this while discussing Theo's video about the announcement blog post.

@patak-dev patak-dev changed the title docs: SvelteKit should be part of the Environment API story docs: add SvelteKit to the Environment API story Dec 4, 2024
@patak-dev patak-dev added the documentation Improvements or additions to documentation label Dec 4, 2024
bluwy
bluwy previously approved these changes Dec 4, 2024
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional & nitpicky, maybe the links to users could all link to github. Right now it's a mix of personal website, github profile, and bsky profile.

@patak-dev
Copy link
Member Author

@bluwy could you suggest which ones should we change? I used websites when I saw good ones.

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's what I was thinking. I guess it feels consistent to me that if someone's interested in the users, they'd also point to their respective github profiles. (but again totally optional if you think otherwise)

docs/blog/announcing-vite6.md Outdated Show resolved Hide resolved
docs/blog/announcing-vite6.md Outdated Show resolved Hide resolved
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
@patak-dev patak-dev merged commit 0a4a5be into main Dec 4, 2024
11 checks passed
@patak-dev patak-dev deleted the docs/v6-announcement-post-tweaks branch December 4, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants