fix: exclude missing dependencies from optimization during SSR #5017
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Optimized based on #4904 , fixed #4700 , and added test cases.
After I submitted the RP #4904 , I am going to add test cases according to the comment of @patak-js .
In the process of building test cases, I found a problem.
For testing, I did not add the script entry point in the
index.html
, it will be dynamically added during SSR.First, if you import a missing dependency that contains multiple entries during SSR, it will execute
server._registerMissingImport
and build a server-based output.Then, when the client imports the same missing dependency that contains multiple entries, it will directly consume the build result of the SSR stage. The build result is only applicable to the server, and importing on the client will cause an error.
In my opinion, there is no need to execute
server._registerMissingImport
during the SSR, because the build result is based on the server, and the optimized dependencies are for the client.If there is anything missing, please remind me.
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).