-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Make import.meta.glob
and import.meta.globEager
generic
#5073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeloliverx
changed the title
Make
feat: Make Sep 24, 2021
import.meta.glob
and import.meta.globEager
genericimport.meta.glob
and import.meta.globEager
generic
Shinigami92
reviewed
Sep 27, 2021
Shinigami92
added
the
p2-nice-to-have
Not breaking anything but nice to have (priority)
label
Sep 27, 2021
Shinigami92
previously approved these changes
Sep 28, 2021
@patak-js seems we have flaky tests again 😭 |
At the risk of this going stale let me know if there is anything else I can do for this PR 😄 |
patak-dev
approved these changes
Feb 12, 2022
Shinigami92
approved these changes
Feb 12, 2022
Thanks for the PR @michaeloliverx, sorry this one took us so long |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first PR so my apologies if I have done anything wrong.
Description
It would be useful if
import.meta.glob
andimport.meta.globEager
were generic functions. This change will allow users to do stuff like this:Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).