-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: upgrade vitepress and add aside sponsors #8363
Conversation
Looks awesome! I think @antfu changes in Vite will end up with us setting |
Thanks! So I think There's no update needed 👍 (I have no idea why test is failing but... |
@kiaking the lint error is there because of a formatting issue. You need to run |
About the aside sponsors, maybe they could stick to the bottom as much as possible so we avoid having layout jumps when changing pages? |
Thanks! Run format and pushed. Sorry about that 😳
No idea! But that's fine I usually run format by hand so 👍
Nice idea. Let me try. I think it's possible by using Currently working on with some other stuff so maybe not soon but soon enough! If this gets merged, I'll include that in another patch 👍 |
Oh, seems like doc fails to build on windows... 🤔 Hmmm... anyone know how to fix this? (do we need doc build test on windows 😳 ? |
You can run The normalization of paths was about the docs error here:
We started to run build docs in Vite's CI. Looks like there is an issue with Windows in this VitePress version |
Yeah seems like. I just got issue on VitePress side 😅 |
we use function slash(str: string) {
return str.replace(/\\/g, '/')
}
function patchWindowsImportPath(path: string) {
if (path.match(/^\w:\\/))
return `file:///${slash(path)}`
else if (path.match(/^\w:\//))
return `file:///${path}`
else
return path
} |
Upgraded VitePress and Windows test is passing, but seems like to failing on playground/css test 😓 However, I also added hero image to the home page 😳 Making sponsors on aside stick to the bottom is not included yet. We have nice fader gradient on the bottom of aside so users can see it's scrollable, and trying to find a way for this to not interact with sponsors and ads 🤔 |
I'm running out of adjectives! I love the new landing page 😍 |
Description
Upgrade VitePress and add sponsors at doc page! Many things have been updated.
"type": "module"
project supportQuestion
Now VitePress can run on project with
"type": "module"
. Do you want to set it to rootpackage.json
? I don't know if there's any meaning to it but... 🤔Only benefit from my side is that we have to set
"type": "module"
to the rootpackage.json
when we want to "locally link VitePress" and use VitePress's dev mode while developing the doc, because VitePress doesn't build cjs modules while on dev mode. This is required only when we want to modify VitePress code and Vite docs at the same time.However, I think I'm the only one who would be doing that so... 😅
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).