fix: respect optimize deps entries #8489
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Once we merged:
We stopped respecting
optimizeDeps.entries
. This PR uses this config option to let users be explicit about which extra entries should be processed before the first deps optimization step.Right now, the optimization is run after every static import (+ dynamic imports that are triggered by the browser while loading the first visited page) are processed. This seems like a good default because processing every dynamic import may be more costly now that we don't do it with the esbuild scanner, especially for apps like StoryBook-like apps.
After this PR, the user should add to entries every dynamic import entry that is commonly used after the first load.
TODO: Tests.
What is the purpose of this pull request?