Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use tsx directly instead of indirect esno #8773

Merged
merged 6 commits into from Jun 25, 2022

Conversation

JounQin
Copy link
Contributor

@JounQin JounQin commented Jun 24, 2022

Description

related #8771

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@netlify
Copy link

netlify bot commented Jun 24, 2022

Deploy Preview for vite-docs-main canceled.

Name Link
🔨 Latest commit 2afb112
🔍 Latest deploy log https://app.netlify.com/sites/vite-docs-main/deploys/62b6fc3d801a5500085265b8

@JounQin
Copy link
Contributor Author

JounQin commented Jun 24, 2022

blocked by privatenumber/get-tsconfig#17 Fixed

@JounQin JounQin force-pushed the chore/tsx_esno branch 2 times, most recently from f972a4f to 6f8b446 Compare Jun 25, 2022
@JounQin
Copy link
Contributor Author

JounQin commented Jun 25, 2022

cc @antfu @Shinigami92

.npmrc Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
.npmrc Outdated Show resolved Hide resolved
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would approve it, but cannot, because there are 3 lines not related to this PR directly 🤔
So other maintainers should decide if they are okay with these lines

@bluwy bluwy changed the title chore: Use tsx directly instead of indirect esno chore: use tsx directly instead of indirect esno Jun 25, 2022
@bluwy bluwy added the p1-chore 🧹 Doesn't change code behavior (priority) label Jun 25, 2022
.npmrc Outdated Show resolved Hide resolved
.npmrc Outdated Show resolved Hide resolved
@@ -14,6 +14,7 @@
],
"scripts": {
"preinstall": "npx only-allow pnpm",
"postinstall": "simple-git-hooks",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will make simple-git-hooks run every time pnpm i is called. But I think it is good to have this for new contributors.
Ideally it is better to turn off side-effects-cache only for simple-git-hooks. I'm not sure if we can do this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we can include it for now until an issue arise, otherwise we can point users to run it manually in the contributing guide.

bluwy
bluwy approved these changes Jun 25, 2022
@patak-dev patak-dev merged commit f018f13 into vitejs:main Jun 25, 2022
11 of 12 checks passed
@JounQin JounQin deleted the chore/tsx_esno branch Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore 🧹 Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants