Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return 500 on proxy error only if possible (fixes #9172) #9175

Merged
merged 1 commit into from Jul 17, 2022

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Jul 17, 2022

Description

#7398 made Vite to return 500 when proxy had an error. But this is not possible if response is already sent.
This PR will make Vite to only return 500 if response is not sent.

fixes #9172

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p3-minor-bug 🔨 An edge case that only affects very specific usage (priority) label Jul 17, 2022
@patak-dev patak-dev merged commit d2f02a8 into vitejs:main Jul 17, 2022
12 checks passed
@sapphi-red sapphi-red deleted the fix/return-500-only-if-possible branch Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug 🔨 An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parse Error: Expected HTTP
2 participants