Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 500 response if the node proxy request fails #7398

merged 1 commit into from Jun 14, 2022


Copy link

@jbergstroem jbergstroem commented Mar 21, 2022


If node-proxy encounters an error (be it in how its set up or issues with fulfilling the request such as ECONNREFUSED), return a http 500 to the consumer instead of silently dropping the request.

Not sure if this is a bug or a feature..

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Instead of silently dropping the request, pass a 500 to the proxy consumer.
@jbergstroem jbergstroem changed the title feat: return a 500 request if the proxy errors feat: return a 500 response if the proxy request fails Mar 21, 2022
Copy link

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is written in the docs of http-proxy.
Also I confirmed it works.

@patak-dev patak-dev changed the title feat: return a 500 response if the proxy request fails feat: 500 response if the node proxy request fails Jun 14, 2022
@patak-dev patak-dev merged commit 73e1775 into vitejs:main Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants