feat: allow backend custom host #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 16, 2020
antfu
requested changes
Oct 20, 2020
| @@ -1,7 +1,7 @@ | |||
| // This file runs in the browser. | |||
|
|
|||
| // injected by serverPluginHmr when served | |||
| declare const __PORT__: number | |||
| declare const __HOST__: string | |||
There was a problem hiding this comment.
We should keep the __PORT__ and let __HOST__ fallback to the original behavior.
There was a problem hiding this comment.
@antfu the original behavior was introduced in rolldown@bb18db2
The new behavior is another way to do samething, but instead of get hostname and port from browser, it will get from directly Vite server.
In old behavior ${socketProtocol}://${location.hostname}:${__PORT__}, location have context from browser.
In this new behavior ${socketProtocol}://${ctx.host.toString()}, ctx will have context from Vite server.
I think that we can revert rolldown@bb18db2 and just let this behavior.
What do you thing?
underfin
approved these changes
Oct 20, 2020
antfu
approved these changes
Oct 20, 2020
|
When you access the backend host, the assets/static limitation can be treated by: // vite.config.js
const cors = require('@koa/cors');
export default {
configureServer: [
({ app }) => {
app.use(cors({ origin: '*' }));
},
({ app }) => {
app.use((ctx, next) => {
// ensure that URL not be http://localhost:3000/localhost:3000/src/assets/logo.png
// when requesting assets/static by frontend host
ctx.request.url = ctx.request.url.replace(`/${ctx.hostname}:${ctx.port}`, '');
return next();
});
},
],
vueTransformAssetUrls: {
base: 'http://localhost:3000/src/',
},
}; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allow to serve the frontend by Vite through a custom host in backend.
Running backend at
https://laravel.test, frontend athttp://localhost:3000and a view in backend like this:This will allow that a different backend host, connect to Websocket correctly #460.
Context:
Instead of get the host info from browser
https://laravel.test, Vite will get from your own host/porthttp://localhost:3000.Limitation:
It's necessary to use this approach #341 (comment) to add CORS into Vite server.
And the backend will need to have a symlink in
publicfolder to serve assets/static files correctly because relative paths will have base URL from backend now, something like this:Fixing partially #341.
Credits:
Update 19/01/2021
For Vite 2.0 is needed change script URL injected in backend view to
http://localhost:3000/@vite/client:And assets symlink will be changed to: