feat(create-vite): add support for custom init commands (create-vue, Nuxt, and SvelteKit)
#9406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was an accidental regression introduced in https://github.com/vitejs/vite/pull/3044/files#diff-49c9292bc736c3c8a1e0773acde605b3bf401a488198b2614885b4e8e7cfaa04L220
So that the casing is consistent between frameworks and variants
Added a few convention here: 1. Options with custom init commands should have the name starting with `custom-`; 2. The custom init command can have a placeholder called `TARGET_DIR`, as the target directory for the project to be created in.
patak-dev
added
the
p2-nice-to-have
tony19
reviewed
Jul 30, 2022
sapphi-red
reviewed
Aug 2, 2022
sapphi-red
approved these changes
Aug 2, 2022
bluwy
approved these changes
Aug 16, 2022
patak-dev
added
p3-significant
antfu
approved these changes
Aug 26, 2022
patak-dev
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #9317
The outcome:
Kapture.2022-07-28.at.17.12.16.mp4
I've also published a package called
create-soda-teston npm, so that you can test it with package managers (e.g.pnpm create soda-test) to see if callingnpm createinsidenpm createreally works.Additional context
I also changed the prompts a little bit, but they are in separate commits, so if this PR gets accepted, please don't squash the commits.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).